Skip to content

Clear all CDM resources when switching to inactive state#541

Open
smudri85 wants to merge 2 commits into
masterfrom
feature/RDKEMW-19750
Open

Clear all CDM resources when switching to inactive state#541
smudri85 wants to merge 2 commits into
masterfrom
feature/RDKEMW-19750

Conversation

@smudri85

Copy link
Copy Markdown
Contributor

Summary: Clear all CDM resources when switching to inactive state.
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-19750

Copilot AI review requested due to automatic review settings June 23, 2026 07:53
@github-actions

Copy link
Copy Markdown

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

@smudri85 smudri85 changed the title Clear all CDM resources when switching to inactive state. Clear all CDM resources when switching to inactive state Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CDM cleanup on state transitions by ensuring all per-session and per-client CDM bookkeeping is cleared when the SessionServer switches to the inactive state, preventing stale session state from being used after resources are torn down.

Changes:

  • Clear m_mediaKeysClients and m_sessionInfo alongside m_mediaKeys during CdmService::switchToInactive().
  • Ensure CDM session/client state does not outlive the active lifecycle of the SessionServer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread media/server/service/source/CdmService.cpp
@github-actions

Copy link
Copy Markdown

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 84.2% to 84.3%
Functions coverage stays unchanged and is: 92.6%

@github-actions

Copy link
Copy Markdown

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 84.2% to 84.3%
Functions coverage stays unchanged and is: 92.6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants