Skip to content

DELIA-68967 : Switching between Xumo Fast Channels and Vipa activated… #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjain008 merged 2 commits into from
Sep 30, 2025
Merged

DELIA-68967 : Switching between Xumo Fast Channels and Vipa activated… #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228cf8b
DELIA-68967 : Switching between Xumo Fast Channels and Vipa activated…
gurpreet319 Sep 30, 2025
e2d6a43
Merge branch 'develop' into topic/DELIA-68967
vjain008 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/jsc/JavaScriptContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ class JavaScriptContext: public JavaScriptContextBase, public NetworkMetricsList
#ifdef ENABLE_AAMP_JSBINDINGS_DYNAMIC
void loadAAMPJSBindingsLib();
void unloadAAMPJSBindingsLib();
void *jscLibHandle = nullptr;
#endif
#endif
JSContextGroupRef mContextGroup;
Expand Down
5 changes: 3 additions & 2 deletions src/jsc/JavaScriptContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ void JavaScriptContext::loadAAMPJSBindingsLib()
{
static const char *aampJSBindingsLib = "libaampjsbindings.so";
static const char *jscLib = "libJavaScriptCore.so";
void *jscLibHandle = dlopen(jscLib, RTLD_NOW | RTLD_GLOBAL);
jscLibHandle = dlopen(jscLib, RTLD_NOW | RTLD_GLOBAL);
if (!jscLibHandle)
{
std::cout<<"dlopen error for jsc library " << dlerror() << std::endl;
Expand All @@ -157,7 +157,6 @@ void JavaScriptContext::loadAAMPJSBindingsLib()
NativeJSLogger::log(ERROR, "failed to load %s and error is %s\n", aampJSBindingsLib, dlerror());
}

dlclose(jscLibHandle);
}
}

Expand All @@ -166,6 +165,8 @@ void JavaScriptContext::unloadAAMPJSBindingsLib()
if (nullptr != gAAMPJSBindings->PlayerLibHandle)
{
dlclose(gAAMPJSBindings->PlayerLibHandle);
dlclose(jscLibHandle);

}
}
#endif
Expand Down