RDKEMW-3106 : Ensure modules path works in all environments#37
Closed
Sid2001-maker wants to merge 3 commits into
Closed
RDKEMW-3106 : Ensure modules path works in all environments#37Sid2001-maker wants to merge 3 commits into
Sid2001-maker wants to merge 3 commits into
Conversation
Reason for change: Cleaned up the code Test Procedure: build should be successful. Risks: low Priority: P2
|
|
| else{ | ||
| char* cwd = getcwd(nullptr,0); | ||
| std::string PWD=cwd; | ||
| if(PWD=="/package") |
Contributor
There was a problem hiding this comment.
We may need to remove this check and need to be done via JSruntimeLauncher by setting environment variable JSRUNTIME_MODULES_PATH=/runtime/modules
| PWD = "/runtime"; | ||
| } | ||
| sModulesPath=PWD+"/modules/"; | ||
| setenv("JSRUNTIME_MODULES_PATH",sModulesPath.c_str(),1); |
Contributor
There was a problem hiding this comment.
We have to remove setenv also
| std::string JavaScriptContextBase::readFile(const char *file) | ||
| { | ||
| std::ifstream src_file(file); | ||
| bool isModules = true; |
madanagopalt
requested changes
Jun 19, 2025
madanagopalt
left a comment
madanagopalt
left a comment
Contributor
There was a problem hiding this comment.
kindly look at comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-3106 : Ensure modules path works in all environments
Reason for change: Cleaned up the code
Test Procedure: build should be successful.
Risks: low
Priority: P2