RDKEMW-5230: JSRuntimeLauncher component - RDKE#35
Closed
gurpreet319 wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 16, 2025 12:51
|
Gurpreet Sarngal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| clearMarks() | ||
| { | ||
| for (var key in this.entries) | ||
| for (var key in entries) |
Contributor
There was a problem hiding this comment.
please retain these changes, as this is common and part of jsruntime
| runFile("modules/linkedjsdom.js", nullptr/*, true*/); | ||
| runFile("modules/linkedjsdomwrapper.js", nullptr/*, true*/); | ||
| runFile("modules/windowwrapper.js", nullptr/*, true*/); | ||
| if(getenv("FIREBOLT_ENDPOINT")!=NULL) |
Contributor
There was a problem hiding this comment.
please retain these changes
| context->runScript(window.str().c_str(),true, url, nullptr, true); | ||
| #endif | ||
| NativeJSLogger::log(INFO, "Running test application: %s\n", url.c_str()); | ||
| NativeJSLogger::log(INFO, "Running test application: %s\n", url); |
Contributor
There was a problem hiding this comment.
please retain these changes . Remove macro check ENABLE_JSRUNTIME_LAUNCHER
| return ; | ||
| } | ||
| JavaScriptContext* context = (JavaScriptContext*)mContextMap[id].context; | ||
| #if defined(ENABLE_JSRUNTIME_LAUNCHER) |
Contributor
There was a problem hiding this comment.
please retain these changes . Remove macro check ENABLE_JSRUNTIME_LAUNCHER
madanagopalt
requested changes
Jun 16, 2025
madanagopalt
left a comment
madanagopalt
left a comment
Contributor
There was a problem hiding this comment.
please loot at comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting changes related to JSRuntimeLauncher.