RDKEMW-3466 : Run Viper JSPP Integrated Player in RDK NativeScript#31
Closed
Sid2001-maker wants to merge 1 commit into
Closed
RDKEMW-3466 : Run Viper JSPP Integrated Player in RDK NativeScript#31Sid2001-maker wants to merge 1 commit into
Sid2001-maker wants to merge 1 commit into
Conversation
Reason for change: Changes for JSRuntime Widget Test Procedure: build should be successful. Risks: low Priority: P2
|
|
| runFile("modules/linkedjsdomwrapper.js", nullptr/*, true*/); | ||
| runFile("modules/windowwrapper.js", nullptr/*, true*/); | ||
| auto FireboltEndpoint = getenv("FIREBOLT_ENDPOINT") ? std::string(getenv("FIREBOLT_ENDPOINT")) : ""; | ||
| std::stringstream firebolt; |
Contributor
There was a problem hiding this comment.
set firebolt variable inside window only if env is set
| } | ||
| JavaScriptContext* context = (JavaScriptContext*)mContextMap[id].context; | ||
| std::stringstream window; | ||
| window<<"window.location = {\"href\":\"file:/" << url << "\"};"; |
Contributor
There was a problem hiding this comment.
remove file:/ prefix for http url's
| #include <cjson/cJSON.h> | ||
| #include <NativeJSRenderer.h> | ||
| #include <NativeJSLogger.h> | ||
| #if defined(ENABLE_JSRUNTIME_SERVER) |
Contributor
There was a problem hiding this comment.
remove jsruntime server parts from here
| ) | ||
| if (ENABLE_JSRUNTIME_LAUNCHER) | ||
| set (JSRUNTIME_LAUNCHER_FILES ${JSRUNTIME_APP_FILES} | ||
| ${JSRUNTIME_COMMON_SOURCE_DIRECTORY}/JSRuntimeServer.cpp |
Contributor
There was a problem hiding this comment.
we don't want jsruntimeserver cpp
madanagopalt
requested changes
May 30, 2025
madanagopalt
left a comment
madanagopalt
left a comment
Contributor
There was a problem hiding this comment.
kindly look at comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Changes for JSRuntime Widget
Test Procedure: build should be successful.
Risks: low
Priority: P2