Skip to content

RDKEMW-20220: Fix for the crash in "WPEWebProcess" during Deepsleep scenario #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dp0000 merged 1 commit into from
Jun 24, 2026
Merged

RDKEMW-20220: Fix for the crash in "WPEWebProcess" during Deepsleep scenario #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion externals/rdk/IIarm/DeviceIARMInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ Remove the entire folder externals/rdk/IARM
#include <libIARM.h>
#include <libIBus.h>
#include <iarmUtil.h>
#include <thread>
#include "libIBusDaemon.h"
#include <hostIf_tr69ReqHandler.h>
#include "tr181api.h"
#include "_base64.h"
#ifdef USE_PREINIT_DECODING
#include "power_controller.h"
#include <thread>
#include <system_error> // for std::system_error
#include <exception> // for std::exception base class
#endif
Expand Down Expand Up @@ -244,6 +244,18 @@ static void IARM_PowerChangeHandler (const PowerController_PowerState_t currentS
{
MW_LOG_INFO("Entering IARM_PowerChangeHandler:State Changed currentState: %d, newState: %d",
currentState, newState);


std::shared_ptr<PlayerExternalsRdkInterface> pInstance =
PlayerExternalsRdkInterface::GetPlayerExternalsRdkInterfaceInstance();
if (newState != POWER_STATE_ON) {
pInstance->SetPowerEvent(true);
MW_LOG_INFO(" Power transition to non-ON state, blocking HDMI events\n");
} else {
pInstance->SetPowerEvent(false);
MW_LOG_INFO(" Power transition to ON, allowing HDMI events\n");
}
Comment thread
dp0000 marked this conversation as resolved.

bool isOnOrStandby = (newState == POWER_STATE_STANDBY || newState == POWER_STATE_ON);
if((currentState == POWER_STATE_STANDBY_DEEP_SLEEP && isOnOrStandby) ||
(prevState == POWER_STATE_STANDBY_DEEP_SLEEP && currentState == POWER_STATE_STANDBY_LIGHT_SLEEP && isOnOrStandby))
Expand Down Expand Up @@ -415,6 +427,12 @@ static void HDMIEventHandler(const char *owner, IARM_EventId_t eventId, void *da
{
std::shared_ptr<PlayerExternalsRdkInterface> pInstance = PlayerExternalsRdkInterface::GetPlayerExternalsRdkInterfaceInstance();


if (pInstance->GetPowerEvent())
{
MW_LOG_WARN(" Skipping HDMI event processing during power transition\n");
return;
}
switch (eventId)
{
case IARM_BUS_DSMGR_EVENT_HDMI_HOTPLUG :
Expand All @@ -428,6 +446,10 @@ static void HDMIEventHandler(const char *owner, IARM_EventId_t eventId, void *da

pInstance->SetHDMIStatus();

// Dispatch to detached worker thread — do NOT block IARM dispatch thread
std::thread([pInstance]() {
pInstance->SetHDMIStatus();
}).detach();
Comment on lines 447 to +452
break;
}
case IARM_BUS_DSMGR_EVENT_HDCP_STATUS :
Expand All @@ -439,6 +461,9 @@ static void HDMIEventHandler(const char *owner, IARM_EventId_t eventId, void *da
hdcpStatus, hdcpStatusStr);

pInstance->SetHDMIStatus();
std::thread([pInstance]() {
pInstance->SetHDMIStatus();
}).detach();
Comment thread
dp0000 marked this conversation as resolved.
break;
}
default:
Expand Down
6 changes: 6 additions & 0 deletions externals/rdk/PlayerExternalsRdkInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,11 @@ void PlayerExternalsRdkInterface::SetResolution(int width, int height)
*/
void PlayerExternalsRdkInterface::SetHDMIStatus()
{
std::unique_lock<std::mutex> lock(m_hdmiStatusMutex, std::try_to_lock);
if (!lock.owns_lock()) {
MW_LOG_WARN("SetHDMIStatus: Already in progress on another thread, skipping\n");
return;
}
bool isConnected = false;
bool isHDCPCompliant = false;
bool isHDCPEnabled = true;
Expand Down Expand Up @@ -306,6 +311,7 @@ void PlayerExternalsRdkInterface::SetHDMIStatus()
}
catch (...) {
MW_LOG_WARN("DeviceSettings unknown exception caught\n");
try { device::Manager::DeInitialize(); } catch (...) {}
}

m_isHDCPEnabled = isHDCPEnabled;
Expand Down
3 changes: 2 additions & 1 deletion externals/rdk/PlayerExternalsRdkInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

#include <memory>
#include "PlayerExternalsInterfaceBase.h"

#include <mutex>
/*
IARM Deprecation Note:
IARM is to be deprecated in favor of DeviceSettings and Firebolt Device API.
Expand All @@ -63,6 +63,7 @@ class PlayerExternalsRdkInterface : public PlayerExternalsInterfaceBase
, public device::Host::IVideoOutputPortEvents
#endif
{
std::mutex m_hdmiStatusMutex;
enum InitState{
NOT_INITIALIZED,
FIREBOLT,
Expand Down
Loading