RDKEMW-20330: [Glass G1 UK -R40.23][Dhruv -40.11]observed "com.comcast.viper" crash on VIPA enabled devices contributing BERR/TECHFAULTOTT with fingerprint 61111371#181
Merged
Conversation
DELIA-70524: [Glass G1 UK -R40.23][Dhruv -40.11]observed "com.comcast.viper" crash on VIPA enabled devices contributing BERR/TECHFAULTOTT with fingerprint 61111371
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent a crash in the CDMI decryptor path on VIPA-enabled devices by ensuring decryption isn’t attempted until valid sink caps are available (and by hardening caps validation in the OCDM session adapter).
Changes:
- Added a dedicated condition variable to signal/wait for
sinkCapsavailability ingstcdmidecryptor. - Introduced a short timed wait (500ms) for caps negotiation completion before decrypt, plus additional NULL-guarding around
sinkCaps. - Hardened
OCDMGSTSessionAdapter::decrypt()to validatecapsis non-null and a realGstCapsbefore callinggst_caps_is_empty().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gst-plugins/drm/gst/gstcdmidecryptor.h | Adds sinkCapsCond to coordinate caps availability with decrypt path. |
| gst-plugins/drm/gst/gstcdmidecryptor.cpp | Initializes/clears sinkCapsCond, signals on sink caps update, and waits/guards to avoid decrypt with NULL sinkCaps. |
| drm/ocdm/OcdmGstSessionAdapter.cpp | Adds caps != nullptr check to prevent crashes when caps is invalid/null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
dp0000
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.