Skip to content

RDKEMW-20330: [Glass G1 UK -R40.23][Dhruv -40.11]observed "com.comcast.viper" crash on VIPA enabled devices contributing BERR/TECHFAULTOTT with fingerprint 61111371#181

Merged
dp0000 merged 1 commit into
support/0.2.0_8.6from
feature/RDKEMW-20330
Jun 24, 2026
Merged

RDKEMW-20330: [Glass G1 UK -R40.23][Dhruv -40.11]observed "com.comcast.viper" crash on VIPA enabled devices contributing BERR/TECHFAULTOTT with fingerprint 61111371#181
dp0000 merged 1 commit into
support/0.2.0_8.6from
feature/RDKEMW-20330

Conversation

@ALSAMEEMA

Copy link
Copy Markdown

No description provided.

DELIA-70524: [Glass G1 UK -R40.23][Dhruv -40.11]observed "com.comcast.viper" crash on VIPA enabled devices contributing BERR/TECHFAULTOTT with fingerprint 61111371
@ALSAMEEMA ALSAMEEMA requested a review from a team as a code owner June 22, 2026 10:47
Copilot AI review requested due to automatic review settings June 22, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent a crash in the CDMI decryptor path on VIPA-enabled devices by ensuring decryption isn’t attempted until valid sink caps are available (and by hardening caps validation in the OCDM session adapter).

Changes:

  • Added a dedicated condition variable to signal/wait for sinkCaps availability in gstcdmidecryptor.
  • Introduced a short timed wait (500ms) for caps negotiation completion before decrypt, plus additional NULL-guarding around sinkCaps.
  • Hardened OCDMGSTSessionAdapter::decrypt() to validate caps is non-null and a real GstCaps before calling gst_caps_is_empty().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
gst-plugins/drm/gst/gstcdmidecryptor.h Adds sinkCapsCond to coordinate caps availability with decrypt path.
gst-plugins/drm/gst/gstcdmidecryptor.cpp Initializes/clears sinkCapsCond, signals on sink caps update, and waits/guards to avoid decrypt with NULL sinkCaps.
drm/ocdm/OcdmGstSessionAdapter.cpp Adds caps != nullptr check to prevent crashes when caps is invalid/null.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@dp0000 dp0000 merged commit 422ec94 into support/0.2.0_8.6 Jun 24, 2026
6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants