RDKEMW-19892: [RDKEMW] [BCM Rogers Monarch IUI V2] Linear trick play (FF/RW/Seek) leads to blank screen, device hang, followed by automatic reboot. Multiple critical processes (gmem, WPENetworkProce, WorkerPoolType: etc.) crash were observed.#180
Open
ALSAMEEMA wants to merge 13 commits into
Conversation
…(FF/RW/Seek) leads to blank screen, device hang, followed by automatic reboot. Multiple critical processes (gmem, WPENetworkProce, WorkerPoolType: etc.) crash were observed. Signed-off-by: ALSAMEEMA <alsameema4@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Widevine multi-key regression where cenc:default_KID (UUID string form from DASH manifests) was not being matched against 16-byte binary Key IDs parsed from PSSH, leading to wrong-key selection during trick play and downstream failures.
Changes:
- Update
WidevineDrmHelper::setDefaultKeyID()to also accept UUID strings (hyphenated / case variants) by decoding them to 16-byte binary before matching. - Add/adjust fallback + logging behavior in
WidevineDrmHelper::getKey()/setDefaultKeyID(). - Add a new unit-test suite covering default key selection scenarios, including multi-key selection via UUID.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
drm/helper/WidevineDrmHelper.cpp |
Implements UUID-to-binary matching for setDefaultKeyID() and adjusts fallback/logging in key selection. |
test/utests/tests/DrmTests/DrmHelperTests.cpp |
Adds unit tests intended to validate correct default key selection across multiple input formats and key counts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ALSAMEEMA
force-pushed
the
feature/RDKEMW-19892
branch
from
50390d0 to
fcc2f4d
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…(FF/RW/Seek) leads to blank screen, device hang, followed by automatic reboot. Multiple critical processes (gmem, WPENetworkProce, WorkerPoolType: etc.) crash were observed.
…(FF/RW/Seek) leads to blank screen, device hang, followed by automatic reboot. Multiple critical processes (gmem, WPENetworkProce, WorkerPoolType: etc.) crash were observed. Signed-off-by: ALSAMEEMA <alsameema4@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.