RDKEMW-18000:Enriching RootFS Manifest with source uri#970
Open
rajkumar154 wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Yocto configuration to include source URI metadata in the generated rootfs manifest, by enabling the embed-source-metadata class at the distro level.
Changes:
- Include a new distro include file from
conf/distro/rdk.confto enable embedding source metadata. - Add
conf/distro/include/embed-source-metadata.incto appendembed-source-metadatatoINHERIT.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/distro/rdk.conf | Requires the new include to enable embedding source metadata during builds. |
| conf/distro/include/embed-source-metadata.inc | Adds INHERIT += "embed-source-metadata" to enrich rootfs manifest metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| require include/rdk-versions.inc | ||
|
|
||
| # Enriching Rootfs manifest with src uri details | ||
| require include/embed-source-metadata.inc |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
conf/distro/include/embed-source-metadata.inc:1
- This new file’s path includes a trailing invisible Unicode control character (it shows up as
embed-source-metadata.inc�). That will make it hard to reference reliably and currently causesrdk.conftorequirea different filename. Please rename this file toconf/distro/include/embed-source-metadata.inc(ASCII only) and ensure anyrequirestatements match the renamed path.
| require include/rdk-versions.inc | ||
|
|
||
| # Enriching Rootfs manifest with src uri details | ||
| require conf/distro/include/embed-source-metadata.inc |
| # RDK component versions | ||
| require include/rdk-versions.inc | ||
|
|
||
| # Enriching Rootfs manifest with src uri details |
| @@ -0,0 +1 @@ | |||
| INHERIT += "embed-source-metadata" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.