RDKEMW-18000:Enriching RootFS Manifest with source uri#968
Open
rajkumar154 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables Yocto’s embed-source-metadata functionality at the distro level to enrich the generated rootfs manifest with source (e.g., SRC_URI) metadata.
Changes:
- Adds a new distro include that appends
embed-source-metadatatoINHERIT. - Requires that include from
conf/distro/rdk.confso it is applied for the distro.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| conf/distro/rdk.conf | Requires the new include to enable embedding source metadata in manifest output. |
| conf/distro/include/embed-source-metadata.inc | Adds INHERIT += "embed-source-metadata" (but the filename currently contains an invisible Unicode character). |
Comments suppressed due to low confidence (1)
conf/distro/include/embed-source-metadata.inc:1
- This file’s name includes an extra invisible Unicode character after
.inc, which preventsrequire include/embed-source-metadata.incfrom finding it and may also cause tooling to treat it as a different extension. Please rename the file toconf/distro/include/embed-source-metadata.inc(ASCII only) and update references accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+142
to
+143
| # Enriching Rootfs manifest with src uri details | ||
| require include/embed-source-metadata.inc |
|
Hi @rajkumar154 : Please check the conf/distro/include/embed-source-metadata.inc filename carefully in a shell-level checkout - it is being reported as having non-printing characters at the end. This will cause confusion later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.