Skip to content

RDKEMW-17667 : Add timezone getter method and onTimeZoneChanged event#83

Open
swethasukumarr wants to merge 1 commit into
developfrom
feature/RDKEMW-17667
Open

RDKEMW-17667 : Add timezone getter method and onTimeZoneChanged event#83
swethasukumarr wants to merge 1 commit into
developfrom
feature/RDKEMW-17667

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 26, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds timezone support to the Firebolt Localization module by introducing a new read-only timeZone getter and a corresponding onTimeZoneChanged subscription event, with implementation and OpenRPC/test coverage updates to keep the API surface consistent across the SDK.

Changes:

  • Added ILocalization::timeZone() getter and ILocalization::subscribeOnTimeZoneChanged(...) event subscription API.
  • Implemented the new getter and subscription in LocalizationImpl.
  • Updated unit/component tests and OpenRPC specs to cover the new method/event and validate payload handling.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/unit/localizationTest.cpp Adds unit tests for timeZone() success/failure and subscribing to onTimeZoneChanged.
test/component/localizationTest.cpp Adds component tests for timeZone() and validates event delivery vs. invalid payloads.
src/localization_impl.h Extends LocalizationImpl interface with timeZone() and subscribeOnTimeZoneChanged(...).
src/localization_impl.cpp Implements timeZone() getter and onTimeZoneChanged subscription wiring.
include/firebolt/localization.h Extends public ILocalization API with the new getter and subscription method + docs.
docs/openrpc/the-spec/firebolt-open-rpc.json Adds OpenRPC entries for Localization.timeZone and Localization.onTimeZoneChanged.
docs/openrpc/openrpc/localization.json Adds module-level OpenRPC entry for timeZone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants