Feature/patchcut0.6.1#75
Closed
swethasukumarr wants to merge 43 commits into
Closed
Conversation
Update develop with latest main
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
feat: prepare for coverity integration
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
chore: coverity integration round 2
RDKEMW-17483 : Add Discovery.watchedV2 alongside Discovery.watched wi…
RDKEMW-19494: Update changelog for patch release 0.6.1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the 0.6.1 patch cut by adding a Discovery.watchedV2 API that returns Result<bool> (accepted/rejected), updating OpenRPC fixtures and tests accordingly, and introducing tooling/workflows to support Coverity-friendly builds and easier native CI/local runs.
Changes:
- Add
Discovery.watchedV2to the public interface + implementation, returningResult<bool>. - Update unit/component tests, demo app, and OpenRPC specs/fixtures for the new method.
- Add Coverity/native build tooling (scripts/docs/workflow) and improve dependency/package discovery (Transport root hinting, GTest config discovery).
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
include/firebolt/discovery.h |
Adds IDiscovery::watchedV2 API contract and docs. |
src/discovery_impl.h |
Declares DiscoveryImpl::watchedV2 override. |
src/discovery_impl.cpp |
Implements watchedV2 with boolean result via helper get. |
test/unit/discoveryTest.cpp |
Adds unit coverage for watchedV2 and payload formation. |
test/component/discoveryTest.cpp |
Adds component coverage for watchedV2 and validates boolean result vs fixture. |
test/api_test_app/apis/discoveryDemo.cpp |
Exposes Discovery.watchedV2 in the interactive demo app. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Adds method definition for Discovery.watchedV2 to the spec used by tests. |
docs/openrpc/openrpc/discovery.json |
Adds module-level watchedV2 definition and examples. |
CHANGELOG.md |
Documents the new Discovery.watchedV2 addition in 0.6.1. |
test/CMakeLists.txt |
Adds logic to locate a locally-installed GTest config (fallback to default discovery). |
CMakeLists.txt |
Adds FIREBOLT_TRANSPORT_ROOT / FireboltTransport_ROOT hinting for deterministic package discovery. |
README.md |
Links to new Coverity build instructions. |
COVERITY.md |
Adds Coverity build guide and reproducible transport bootstrap documentation. |
cov_build.sh |
Adds a Coverity-friendly Debug + tests build script with optional FireboltTransport bootstrap. |
coverity_local.sh |
Adds local wrapper that delegates to cov_build.sh. |
build_dependencies.sh |
Adds a script to install core build dependencies (incl. gtest/json/schema validator/websocketpp). |
.github/workflows/native_full_build.yml |
Adds a native-container build workflow that runs dependency install + cov_build.sh. |
Makefile.act |
Adds act helpers to run the native workflow locally. |
.gitignore |
Ignores Coverity deps prefix and act logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.