RDKEMW-17483 : Add Discovery.watchedV2 alongside Discovery.watched wi…#72
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Discovery.watchedV2 API alongside the existing Discovery.watched, mirroring the same request payload logic but returning a bool indicating whether the platform accepted the notification. This extends the Firebolt C++ client’s Discovery module surface area while keeping OpenRPC fixtures aligned.
Changes:
- Introduces
IDiscovery::watchedV2(...) -> Result<bool>and implements it inDiscoveryImplusing the same parameter construction aswatched. - Adds unit/component coverage and updates the API test app demo to expose the new method.
- Updates OpenRPC specs/fixtures to define
Discovery.watchedV2and its boolean result.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/discoveryTest.cpp | Adds unit tests for watchedV2 success and payload serialization. |
| test/component/discoveryTest.cpp | Adds a component test calling watchedV2. |
| test/api_test_app/apis/discoveryDemo.cpp | Adds CLI/demo support for invoking Discovery.watchedV2. |
| src/discovery_impl.h | Extends DiscoveryImpl with watchedV2 override. |
| src/discovery_impl.cpp | Implements DiscoveryImpl::watchedV2 and returns a parsed boolean result. |
| include/firebolt/discovery.h | Extends public Discovery interface with watchedV2 documentation + signature. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Adds the Discovery.watchedV2 OpenRPC method definition. |
| docs/openrpc/openrpc/discovery.json | Adds the module-level watchedV2 OpenRPC method definition. |
Contributor
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th same logic