Skip to content

RDKEMW-17483 : Add Discovery.watchedV2 alongside Discovery.watched wi…#72

Merged
swethasukumarr merged 2 commits into
developfrom
feature/RDKEMW-17483n
Jun 11, 2026
Merged

RDKEMW-17483 : Add Discovery.watchedV2 alongside Discovery.watched wi…#72
swethasukumarr merged 2 commits into
developfrom
feature/RDKEMW-17483n

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

…th same logic

Copilot AI review requested due to automatic review settings June 10, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Discovery.watchedV2 API alongside the existing Discovery.watched, mirroring the same request payload logic but returning a bool indicating whether the platform accepted the notification. This extends the Firebolt C++ client’s Discovery module surface area while keeping OpenRPC fixtures aligned.

Changes:

  • Introduces IDiscovery::watchedV2(...) -> Result<bool> and implements it in DiscoveryImpl using the same parameter construction as watched.
  • Adds unit/component coverage and updates the API test app demo to expose the new method.
  • Updates OpenRPC specs/fixtures to define Discovery.watchedV2 and its boolean result.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/unit/discoveryTest.cpp Adds unit tests for watchedV2 success and payload serialization.
test/component/discoveryTest.cpp Adds a component test calling watchedV2.
test/api_test_app/apis/discoveryDemo.cpp Adds CLI/demo support for invoking Discovery.watchedV2.
src/discovery_impl.h Extends DiscoveryImpl with watchedV2 override.
src/discovery_impl.cpp Implements DiscoveryImpl::watchedV2 and returns a parsed boolean result.
include/firebolt/discovery.h Extends public Discovery interface with watchedV2 documentation + signature.
docs/openrpc/the-spec/firebolt-open-rpc.json Adds the Discovery.watchedV2 OpenRPC method definition.
docs/openrpc/openrpc/discovery.json Adds the module-level watchedV2 OpenRPC method definition.

Comment thread test/component/discoveryTest.cpp
@swethasukumarr swethasukumarr requested a review from satlead June 10, 2026 19:02
@swethasukumarr swethasukumarr self-assigned this Jun 10, 2026

@satlead satlead left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary measure for realignment

@swethasukumarr swethasukumarr merged commit ddc3d19 into develop Jun 11, 2026
12 checks passed
@swethasukumarr swethasukumarr deleted the feature/RDKEMW-17483n branch June 11, 2026 18:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
@tomasz-blasz

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants