Update fossid_integration_stateless_diffscan_target_repo.yml#50
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Fossid stateless diff scan GitHub Action to support both automatic scanning for internal PRs and manual scanning (including fork PRs) via workflow dispatch.
Changes:
- Add
workflow_dispatchtrigger with apr_numberinput to manually scan any PR. - Split workflow into an internal PR path and a manual-dispatch path that resolves PR refs before invoking the reusable Fossid workflow.
- Pin the reusable workflow reference to
@1.0.0instead of a moving branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml:64
secrets:mapping entries are indented more than necessary, and inconsistent with other workflows in this repo (e.g.,.github/workflows/auto_merge_manifest_pr_caller.yml). While valid YAML, normalizing indentation improves readability and reduces the chance of accidental nesting errors during future edits.
secrets:
FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }}
FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }}
FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }}
FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }}
Comment on lines
+55
to
+59
| uses: rdkcentral/build_tools_workflows/.github/workflows/fossid_integration_stateless_diffscan.yml@1.0.0 | ||
| with: | ||
| base_ref: ${{ needs.resolve-pr-refs.outputs.base_ref }} | ||
| compare_ref: ${{ needs.resolve-pr-refs.outputs.head_sha }} | ||
| pr_number: ${{ github.event.inputs.pr_number }} |
Comment on lines
4
to
+6
| pull_request: | ||
| branches: | ||
| - develop | ||
| types: [opened, synchronize, reopened] | ||
| workflow_dispatch: # NEW: manual trigger |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
.github/workflows/fossid_integration_stateless_diffscan_target_repo.yml:64
- The secrets mapping under
call-fossid-dispatchis over-indented compared to the rest of the file. YAML will parse it, but the inconsistent indentation makes the workflow harder to read and easier to mis-edit.
secrets:
FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }}
FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }}
FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }}
FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }}
Comment on lines
+55
to
+59
| uses: rdkcentral/build_tools_workflows/.github/workflows/fossid_integration_stateless_diffscan.yml@1.0.0 | ||
| with: | ||
| base_ref: ${{ needs.resolve-pr-refs.outputs.base_ref }} | ||
| compare_ref: ${{ needs.resolve-pr-refs.outputs.head_sha }} | ||
| pr_number: ${{ github.event.inputs.pr_number }} |
Comment on lines
+42
to
+43
| const prNumber = parseInt(context.payload.inputs.pr_number, 10); | ||
| const { data: pr } = await github.rest.pulls.get({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.