Override license paths instead of resetting them when merging#45
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates how PackageBuilder merges root filesystems to avoid producing OCI whiteout entries (.wh.*) during repacks, which can later cause issues when syncing/extracting with rsync.
Changes:
- Replace the “reset paths” deletion step with an “override paths” resync approach during merge.
- Switch the primary
rsynccall from shell-string execution to argv-based execution (execv). - Add a
resync()helper that re-copies specified subtrees with differentrsyncstrategies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BunioFH
reviewed
Jun 18, 2026
BunioFH
added a commit
to rdkcentral/meta-bolt-wpe
that referenced
this pull request
Jun 19, 2026
to be removed after rdkcentral/bolt-tools#45 is resolved Change-Id: I59bee9260b3515aafdad77fccd0ecdbb233fb1d5
BunioFH
added a commit
to rdkcentral/meta-bolt-wpe
that referenced
this pull request
Jun 22, 2026
to be removed after rdkcentral/bolt-tools#45 is resolved Change-Id: I5b2fb0900f8dd32d4b39cbf9ba7f2982dab90ca5
This avoids generating .wh.* files by umoci that are unreadable by rsync. Ref: #RDKEAPPRT-861
BunioFH
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids generating .wh.* files by umoci that are unreadable by rsync.