Skip to content

RDKB-65687: Multiclient reconnect#33

Merged
gsathish86 merged 21 commits into
rdkcentral:developfrom
rranga540:multicliet_reconnect
Jun 22, 2026
Merged

RDKB-65687: Multiclient reconnect#33
gsathish86 merged 21 commits into
rdkcentral:developfrom
rranga540:multicliet_reconnect

Conversation

@rranga540

Copy link
Copy Markdown
Contributor

Impacted Platforms: TXB8, TXB7, SXB10, VXB10
Reason for change: Implementation for multiclient reconnect
Test Procedure: Trigger a client connectivity test case with clientCount and auto_reconnect fields
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com

rranga540 added 21 commits May 8, 2026 06:43
Impacted Platforms: All rdkb platforms
Reason for change: Dummy
Test Procedure: Dummy
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com
Impacted Platforms: All rdkb platforms
Reason for change: Dummy
Test Procedure: Dummy
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com
Impacted Platforms: TXB8, TXB7, SXB10, VXB10
Reason for change: Implementation for multiclient reconnect
Test Procedure: Trigger a client connectivity test case with clientCount and auto_reconnect fields
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com
Copilot AI review requested due to automatic review settings June 22, 2026 08:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements multi-client reconnect support for STA management tests by tracking disconnect/reconnect state per connected client and updating STA manager operations to use per-client interface/vap details during disconnect/reconnect flows.

Changes:

  • Move reconnect state (is_disconnection_sent, reconnect_timer) from sta_test_t to connected_client_info_t to support multi-client behavior.
  • Update STA management timeout/frame-filter logic to reconnect/disconnect clients individually.
  • Update STA manager disconnect/remove/reconnect paths to use client-specific VAP index/info and improve logging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/tests/wlan_emu_test_param_sta_management.cpp Per-client reconnect/disconnect handling in timeout and frame filter paths.
src/sta/wlan_emu_sta_mgr.cpp Adjust STA remove/disconnect/reconnect to use per-client indices; add logging; reposition disconnect call.
inc/wlan_emu_common.h Move reconnect tracking fields into connected_client_info_t for multi-client support.
Comments suppressed due to low confidence (1)

src/tests/wlan_emu_test_param_sta_management.cpp:1252

  • For open security, association is detected via assoc_resp but is_disconnection_sent (and the per-client reconnect_timer) are not cleared. With reconnect enabled this can cause the client to be treated as still disconnected and repeatedly reconnected. Clear these fields on successful association for both open (assoc_resp) and secured (eapol-msg3) cases.
                if (step->u.sta_test->sta_vap_config->u.sta_info.security.mode ==
                    wifi_security_mode_none) {
                    if (wlan_emu_frm80211_ops_type_assoc_resp == msg->get_frm80211_ops_type()) {
                        client_info->is_station_associated = true;
                        wlan_emu_print(wlan_emu_log_level_dbg,
                            "%s:%d: captured assoc response for open security for mac %s\n",
                            __func__, __LINE__, client_macaddr);
                    }
                } else {
                    if (wlan_emu_frm80211_ops_type_eapol == msg->get_frm80211_ops_type()) {
                        if (strncmp(msg->get_msg_name(), "eapol-msg3", strlen("eapol-msg3")) == 0) {
                            client_info->is_station_associated = true;
                            client_info->is_disconnection_sent = false;
                            wlan_emu_print(wlan_emu_log_level_dbg,
                                "%s:%d: captured eapol-msg3 for %s\n", __func__, __LINE__,
                                client_macaddr);
                        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
@gsathish86 gsathish86 merged commit 552c69c into rdkcentral:develop Jun 22, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants