RDKB-63936, RDKB-58243: Multiclient support for cci#32
Conversation
* RDKB-58243: cci support for 300 clients Reason for change: With these change onewifi test suite can support with 1 to 300 clients Test Procedure: Refer to the ticket. Risks: Low Priority: P1 Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350 Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> (cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09) * removed duplicate of class definition. --------- Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> Co-authored-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> Co-authored-by: Sanjay Venkatesan <Sanjay_Venkatesan@Comcast.com> RDKB-63936: Multiclient for cci (rdkcentral#15) RDKB-63936: Multiclient for cci Impacted Platforms: TCXB7, TCXB8, VXB10 Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta management step Risks: Low Priority: P2 Signed-off-by:RaviShankar.R_Rangaraj@comcast.com RDKB-64676 - Failed to free client (rdkcentral#25) * Failed to free client * Failed to free clients * RDKB-64676 - Failed to free client
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extends the WLAN emulator to support multiple simulated STA clients per test step, switching from a single STA key/MAC to per-client tracking and updating HAL initialization to use an interface-map query.
Changes:
- Add multi-client support via
ClientCountconfig, per-client MAC/key tracking, and JSON result output per connected client. - Update simulated STA manager APIs to operate on
connected_client_info_tand initialize usingwifi_hal_getInterfaceMap. - Persist/read the supported simulated client count via syscfg, with input validation in the CCI handler.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/wlan_emu_ui_mgr.cpp | Removes obsolete HAL capability prototype (supports new interface-map init). |
| src/tests/wlan_emu_test_param_sta_management.cpp | Adds ClientCount parsing, per-client result JSON, per-client timeout/heartbeat/frame-filter logic, and queue lifecycle. |
| src/sta/wlan_emu_sta_mgr.cpp | Refactors STA CRUD APIs to accept per-client info, adds multi-client loop in add_sta, and changes init to accept interface map. |
| src/gateway_cci/wlan_emu.cpp | Switches to wifi_hal_getInterfaceMap, adds syscfg persistence for simulated client count, and tightens validation. |
| src/external_agent_cci/wlan_ext_emu_test_step_param_sta_management.cpp | Removes resetting is_decoded on external agent removal path. |
| inc/wlan_emu_sta_mgr.h | Updates STA manager method signatures for per-client operations and interface-map init. |
| inc/wlan_emu_common.h | Introduces connected_client_info_t and adds multi-client fields to sta_test_t. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1
Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Sanjay Venkatesan Sanjay_Venkatesan@Comcast.com
RDKB-63936: Multiclient for cci (#15)
RDKB-63936: Multiclient for cci
Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta
management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com
RDKB-64676 - Failed to free client (#25)
Failed to free client
Failed to free clients
RDKB-64676 - Failed to free client