Skip to content

RDKB-63936, RDKB-58243: Multiclient support for cci#32

Merged
gsathish86 merged 2 commits into
rdkcentral:mainfrom
rranga540:multiclient_main
Jun 17, 2026
Merged

RDKB-63936, RDKB-58243: Multiclient support for cci#32
gsathish86 merged 2 commits into
rdkcentral:mainfrom
rranga540:multiclient_main

Conversation

@rranga540

Copy link
Copy Markdown
Contributor
  • RDKB-58243: cci support for 300 clients

Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1

Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)

  • removed duplicate of class definition.

Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Sanjay Venkatesan Sanjay_Venkatesan@Comcast.com

RDKB-63936: Multiclient for cci (#15)

RDKB-63936: Multiclient for cci

Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta
management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com

RDKB-64676 - Failed to free client (#25)

  • Failed to free client

  • Failed to free clients

  • RDKB-64676 - Failed to free client

* RDKB-58243: cci support for 300 clients

Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1

Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)

* removed duplicate of class definition.

---------

Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
Co-authored-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
Co-authored-by: Sanjay Venkatesan <Sanjay_Venkatesan@Comcast.com>

RDKB-63936: Multiclient for cci (rdkcentral#15)

RDKB-63936: Multiclient for cci

Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step
Test Procedure: Trigger a test with client count variable in sta
                management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com

RDKB-64676  - Failed to free client (rdkcentral#25)

* Failed to free client

* Failed to free clients

* RDKB-64676 - Failed to free client
Copilot AI review requested due to automatic review settings June 17, 2026 05:55
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
gsathish86
SanjayVenkatesan190
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR extends the WLAN emulator to support multiple simulated STA clients per test step, switching from a single STA key/MAC to per-client tracking and updating HAL initialization to use an interface-map query.

Changes:

  • Add multi-client support via ClientCount config, per-client MAC/key tracking, and JSON result output per connected client.
  • Update simulated STA manager APIs to operate on connected_client_info_t and initialize using wifi_hal_getInterfaceMap.
  • Persist/read the supported simulated client count via syscfg, with input validation in the CCI handler.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
src/ui/wlan_emu_ui_mgr.cpp Removes obsolete HAL capability prototype (supports new interface-map init).
src/tests/wlan_emu_test_param_sta_management.cpp Adds ClientCount parsing, per-client result JSON, per-client timeout/heartbeat/frame-filter logic, and queue lifecycle.
src/sta/wlan_emu_sta_mgr.cpp Refactors STA CRUD APIs to accept per-client info, adds multi-client loop in add_sta, and changes init to accept interface map.
src/gateway_cci/wlan_emu.cpp Switches to wifi_hal_getInterfaceMap, adds syscfg persistence for simulated client count, and tightens validation.
src/external_agent_cci/wlan_ext_emu_test_step_param_sta_management.cpp Removes resetting is_decoded on external agent removal path.
inc/wlan_emu_sta_mgr.h Updates STA manager method signatures for per-client operations and interface-map init.
inc/wlan_emu_common.h Introduces connected_client_info_t and adds multi-client fields to sta_test_t.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/gateway_cci/wlan_emu.cpp
Comment thread src/gateway_cci/wlan_emu.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
@gsathish86 gsathish86 merged commit 20fd1a0 into rdkcentral:main Jun 17, 2026
2 of 3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants