Skip to content

RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving …#31

Merged
gsathish86 merged 2 commits into
rdkcentral:mainfrom
Nikita-Hakai:sync_bus_abstract
Jun 18, 2026
Merged

RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving …#31
gsathish86 merged 2 commits into
rdkcentral:mainfrom
Nikita-Hakai:sync_bus_abstract

Conversation

@Nikita-Hakai

Copy link
Copy Markdown

…and setting bus data property types.

This reverts commit 13a7190.

…and setting bus data property types.

This reverts commit 13a7190.
Copilot AI review requested due to automatic review settings June 16, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts commit 13a7190... and updates the WLAN emulator’s bus abstraction to support generalized “property-based” bus payloads (via bus_data_prop_t) when retrieving and setting bus data property types, aligning RBUS event/method handling with the new payload representation.

Changes:

  • Updated event callback signatures in UI/test code to consume bus_data_prop_t and improved allocation/error handling for string payload copying.
  • Enhanced the RDKB RBUS layer to parse rbusObject_t into a linked list of bus_data_prop_t entries (including deep-copied string/bytes values) and to free that structure safely.
  • Updated public headers to reflect the new callback types.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ui/wlan_emu_ui_mgr.cpp Switches webconfig event handler to bus_data_prop_t and adds payload validation / safer allocation.
src/tests/wlan_emu_test_param_stats_get.cpp Updates stats subscription handler signature and improves cleanup/error paths.
src/bus/rdkb/wlan_emu_bus.cpp Implements RBUS↔bus property conversion for events/methods and adds cleanup for property lists.
inc/wlan_emu_ui_mgr.h Updates callback function pointer types to bus_data_prop_t.
inc/wlan_emu_test_params.h Updates stats handler declaration to bus_data_prop_t.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ui/wlan_emu_ui_mgr.cpp
Comment thread src/tests/wlan_emu_test_param_stats_get.cpp
@gsathish86 gsathish86 merged commit 18eacfd into rdkcentral:main Jun 18, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants