RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving …#31
Merged
Merged
Conversation
…and setting bus data property types. This reverts commit 13a7190.
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 13a7190... and updates the WLAN emulator’s bus abstraction to support generalized “property-based” bus payloads (via bus_data_prop_t) when retrieving and setting bus data property types, aligning RBUS event/method handling with the new payload representation.
Changes:
- Updated event callback signatures in UI/test code to consume
bus_data_prop_tand improved allocation/error handling for string payload copying. - Enhanced the RDKB RBUS layer to parse
rbusObject_tinto a linked list ofbus_data_prop_tentries (including deep-copied string/bytes values) and to free that structure safely. - Updated public headers to reflect the new callback types.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/wlan_emu_ui_mgr.cpp | Switches webconfig event handler to bus_data_prop_t and adds payload validation / safer allocation. |
| src/tests/wlan_emu_test_param_stats_get.cpp | Updates stats subscription handler signature and improves cleanup/error paths. |
| src/bus/rdkb/wlan_emu_bus.cpp | Implements RBUS↔bus property conversion for events/methods and adds cleanup for property lists. |
| inc/wlan_emu_ui_mgr.h | Updates callback function pointer types to bus_data_prop_t. |
| inc/wlan_emu_test_params.h | Updates stats handler declaration to bus_data_prop_t. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and setting bus data property types.
This reverts commit 13a7190.