RDKB-65612: Real client implementation for cci#30
Merged
Conversation
Impacted Platforms: All RDKB Platforms Reason for change: Test Procedure: Risks: Priority: Signed-off-by:Pavithra_Sundaravadivel@comcast.com Change-Id: I808047e310445e5e947139fb4f3a86e209726579
This reverts commit b597cd3.
Impacted Platforms: All RDKB Platforms Reason for change: Test Procedure: Risks: Priority: Signed-off-by:Pavithra_Sundaravadivel@comcast.com
Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Real client connectivity implementation
Test Procedure: 1. add statio type as "Real" in schema.json
2. Trigger a test
Risks: Low
Priority: P2
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds support for “Real” client workflows across station-management and iperf steps, including new TDA endpoints and additional client model types.
Changes:
- Introduces
wlan_emu_real_sta_mgr_tand wires it through test execution to handle real-client connect/disconnect requests. - Extends JSON decoding and step execution for iperf and station management to support
ConnectionType=Real, device metadata, and service preferences. - Adds new endpoint types/URLs for real-client connection, disconnection, and iperf requests; also fixes IP validation logic.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/cci_wifi_utils.cpp | Adds command logging; fixes is_valid_ip() behavior for IPv4/IPv6 parsing. |
| src/ui/wlan_emu_ui_mgr.cpp | Adds JSON dumping and parses ConnectionType and extra fields for iperf steps; adds new TDA endpoints. |
| src/tests/wlan_emu_tests.cpp | Passes the new real STA manager into steps/tests. |
| src/tests/wlan_emu_test_param_sta_management.cpp | Adds real-client station management flow, metadata parsing, timeouts, and frame filtering adjustments. |
| src/tests/wlan_emu_test_param_iperf_server.cpp | Adds local iperf server spawn/stop logic for real clients. |
| src/tests/wlan_emu_test_param_iperf_client.cpp | Adds TDA iperf request posting for real clients and real-client timeout handling. |
| src/sta/wlan_emu_real_sta_mgr.cpp | New manager that posts connect/disconnect requests for real clients to TDA. |
| src/messages/wlan_emu_msg.cpp | Adjusts radio-index selection for real-client flows via VAP lookup. |
| src/gateway_cci/wlan_emu.cpp | Wires m_real_sta_mgr into all test constructors. |
| inc/wlan_emu_ui_mgr.h | Moves cci_post_result_to_tda declaration. |
| inc/wlan_emu_tests.h | Adds wlan_emu_real_sta_mgr_t plumbing to tests and constructors. |
| inc/wlan_emu_test_params.h | Adds m_real_sta_mgr to step params; updates step manager injection; adds real STA timeout declaration. |
| inc/wlan_emu_real_sta_mgr.h | New public header for the real STA manager. |
| inc/wlan_emu_common.h | Adds client_connection_type_real, new STA model types, new endpoint types, and new config fields. |
| inc/wlan_emu.h | Adds m_real_sta_mgr to main wlan_emu_t. |
| inc/wlan_common_utils.h | Adds enum-to-string mappings for new STA model types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Real client connectivity implementation
Test Procedure: 1. add statio type as "Real" in schema.json
2. Trigger a test
Risks: Low
Priority: P2