Skip to content

RDKB-65612: Real client implementation for cci#30

Merged
gsathish86 merged 38 commits into
rdkcentral:developfrom
rranga540:real_client
Jun 17, 2026
Merged

RDKB-65612: Real client implementation for cci#30
gsathish86 merged 38 commits into
rdkcentral:developfrom
rranga540:real_client

Conversation

@rranga540

Copy link
Copy Markdown
Contributor

Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Real client connectivity implementation
Test Procedure: 1. add statio type as "Real" in schema.json
                2. Trigger a test
Risks: Low
Priority: P2

pavithrasundaravadivel and others added 8 commits May 15, 2026 07:48
Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Real client connectivity implementation
Test Procedure: 1. add statio type as "Real" in schema.json
                2. Trigger a test
Risks: Low
Priority: P2
Copilot AI review requested due to automatic review settings June 16, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds support for “Real” client workflows across station-management and iperf steps, including new TDA endpoints and additional client model types.

Changes:

  • Introduces wlan_emu_real_sta_mgr_t and wires it through test execution to handle real-client connect/disconnect requests.
  • Extends JSON decoding and step execution for iperf and station management to support ConnectionType=Real, device metadata, and service preferences.
  • Adds new endpoint types/URLs for real-client connection, disconnection, and iperf requests; also fixes IP validation logic.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/utils/cci_wifi_utils.cpp Adds command logging; fixes is_valid_ip() behavior for IPv4/IPv6 parsing.
src/ui/wlan_emu_ui_mgr.cpp Adds JSON dumping and parses ConnectionType and extra fields for iperf steps; adds new TDA endpoints.
src/tests/wlan_emu_tests.cpp Passes the new real STA manager into steps/tests.
src/tests/wlan_emu_test_param_sta_management.cpp Adds real-client station management flow, metadata parsing, timeouts, and frame filtering adjustments.
src/tests/wlan_emu_test_param_iperf_server.cpp Adds local iperf server spawn/stop logic for real clients.
src/tests/wlan_emu_test_param_iperf_client.cpp Adds TDA iperf request posting for real clients and real-client timeout handling.
src/sta/wlan_emu_real_sta_mgr.cpp New manager that posts connect/disconnect requests for real clients to TDA.
src/messages/wlan_emu_msg.cpp Adjusts radio-index selection for real-client flows via VAP lookup.
src/gateway_cci/wlan_emu.cpp Wires m_real_sta_mgr into all test constructors.
inc/wlan_emu_ui_mgr.h Moves cci_post_result_to_tda declaration.
inc/wlan_emu_tests.h Adds wlan_emu_real_sta_mgr_t plumbing to tests and constructors.
inc/wlan_emu_test_params.h Adds m_real_sta_mgr to step params; updates step manager injection; adds real STA timeout declaration.
inc/wlan_emu_real_sta_mgr.h New public header for the real STA manager.
inc/wlan_emu_common.h Adds client_connection_type_real, new STA model types, new endpoint types, and new config fields.
inc/wlan_emu.h Adds m_real_sta_mgr to main wlan_emu_t.
inc/wlan_common_utils.h Adds enum-to-string mappings for new STA model types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/utils/cci_wifi_utils.cpp
Comment thread src/ui/wlan_emu_ui_mgr.cpp
Comment thread src/ui/wlan_emu_ui_mgr.cpp
Comment thread src/ui/wlan_emu_ui_mgr.cpp
Comment thread src/ui/wlan_emu_ui_mgr.cpp
Comment thread src/sta/wlan_emu_real_sta_mgr.cpp
Comment thread src/sta/wlan_emu_real_sta_mgr.cpp
Comment thread src/messages/wlan_emu_msg.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
@gsathish86 gsathish86 merged commit 03724eb into rdkcentral:develop Jun 17, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants