RDKB-58243: cci support for 300 clients. (#7)#29
Conversation
* RDKB-58243: cci support for 300 clients Reason for change: With these change onewifi test suite can support with 1 to 300 clients Test Procedure: Refer to the ticket. Risks: Low Priority: P1 Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350 Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> (cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09) * removed duplicate of class definition. --------- Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> Co-authored-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk> Co-authored-by: Sanjay Venkatesan <Sanjay_Venkatesan@Comcast.com> RDKB-63936: Multiclient for cci (rdkcentral#15) RDKB-63936: Multiclient for cci Impacted Platforms: TCXB7, TCXB8, VXB10 Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta management step Risks: Low Priority: P2 Signed-off-by:RaviShankar.R_Rangaraj@comcast.com RDKB-64676 - Failed to free client (rdkcentral#25) * Failed to free client * Failed to free clients * RDKB-64676 - Failed to free client
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extends the WLAN emulator to support multiple simulated STA clients per test step, moving from a single sta_test->key/mac model to tracking per-client state (MAC/key/association) via a queue, and switches STA manager initialization to use a HAL-provided interface map sized by a configurable simulated client limit.
Changes:
- Add per-client tracking (
connected_client_info_t) and update STA management flows (add/remove/reconnect/disconnect/heartbeat/frame filtering) to operate per connected client. - Introduce
ClientCountparsing in STA management step configs and emit per-client MACs in results JSON. - Replace
wifi_hal_getHalCapability()usage withwifi_hal_getInterfaceMap()and persist simulated client count via syscfg.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/wlan_emu_ui_mgr.cpp | Removes old HAL capability API declaration in favor of newer interface-map based init. |
| src/tests/wlan_emu_test_param_sta_management.cpp | Adds ClientCount support and refactors step execution/timeout/removal/frame-filter logic for multiple clients. |
| src/sta/wlan_emu_sta_mgr.cpp | Updates STA manager APIs for per-client operations, adds multi-client connect loop and interface-map init path. |
| src/gateway_cci/wlan_emu.cpp | Adds syscfg persistence and bounds for simulated client count and switches to HAL interface map API. |
| src/external_agent_cci/wlan_ext_emu_test_step_param_sta_management.cpp | Removes is_decoded reset on external agent step path. |
| inc/wlan_emu_sta_mgr.h | Updates public STA manager API signatures for per-client operations and interface-map init. |
| inc/wlan_emu_common.h | Introduces connected_client_info_t and extends sta_test_t with multi-client / IP / DHCP fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1
Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Sanjay Venkatesan Sanjay_Venkatesan@Comcast.com
RDKB-63936: Multiclient for cci (#15)
RDKB-63936: Multiclient for cci
Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta
management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com
RDKB-64676 - Failed to free client (#25)
Failed to free client
Failed to free clients
RDKB-64676 - Failed to free client