Skip to content

RDKB-58243: cci support for 300 clients. (#7)#29

Merged
gsathish86 merged 1 commit into
rdkcentral:mainfrom
rranga540:multiclient_main
Jun 16, 2026
Merged

RDKB-58243: cci support for 300 clients. (#7)#29
gsathish86 merged 1 commit into
rdkcentral:mainfrom
rranga540:multiclient_main

Conversation

@rranga540

Copy link
Copy Markdown
Contributor
  • RDKB-58243: cci support for 300 clients

Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1

Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)

  • removed duplicate of class definition.

Signed-off-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Viviane Cordeiro viviane.cordeirodasilva@sky.uk
Co-authored-by: Sanjay Venkatesan Sanjay_Venkatesan@Comcast.com

RDKB-63936: Multiclient for cci (#15)

RDKB-63936: Multiclient for cci

Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step Test Procedure: Trigger a test with client count variable in sta
management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com

RDKB-64676 - Failed to free client (#25)

  • Failed to free client

  • Failed to free clients

  • RDKB-64676 - Failed to free client

* RDKB-58243: cci support for 300 clients

Reason for change: With these change onewifi test suite can support with 1 to 300 clients
Test Procedure: Refer to the ticket.
Risks: Low
Priority: P1

Change-Id: Ie8b89672a4a37e410dadb831dd901d33ae228350
Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
(cherry picked from commit 58750c449148532ef778f538ad56ae1c80c7bf09)

* removed duplicate of class definition.

---------

Signed-off-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
Co-authored-by: Viviane Cordeiro <viviane.cordeirodasilva@sky.uk>
Co-authored-by: Sanjay Venkatesan <Sanjay_Venkatesan@Comcast.com>

RDKB-63936: Multiclient for cci (rdkcentral#15)

RDKB-63936: Multiclient for cci

Impacted Platforms: TCXB7, TCXB8, VXB10
Reason for change: Implemenation of multiclient step
Test Procedure: Trigger a test with client count variable in sta
                management step
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com

RDKB-64676  - Failed to free client (rdkcentral#25)

* Failed to free client

* Failed to free clients

* RDKB-64676 - Failed to free client
Copilot AI review requested due to automatic review settings June 16, 2026 06:41
@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR extends the WLAN emulator to support multiple simulated STA clients per test step, moving from a single sta_test->key/mac model to tracking per-client state (MAC/key/association) via a queue, and switches STA manager initialization to use a HAL-provided interface map sized by a configurable simulated client limit.

Changes:

  • Add per-client tracking (connected_client_info_t) and update STA management flows (add/remove/reconnect/disconnect/heartbeat/frame filtering) to operate per connected client.
  • Introduce ClientCount parsing in STA management step configs and emit per-client MACs in results JSON.
  • Replace wifi_hal_getHalCapability() usage with wifi_hal_getInterfaceMap() and persist simulated client count via syscfg.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
src/ui/wlan_emu_ui_mgr.cpp Removes old HAL capability API declaration in favor of newer interface-map based init.
src/tests/wlan_emu_test_param_sta_management.cpp Adds ClientCount support and refactors step execution/timeout/removal/frame-filter logic for multiple clients.
src/sta/wlan_emu_sta_mgr.cpp Updates STA manager APIs for per-client operations, adds multi-client connect loop and interface-map init path.
src/gateway_cci/wlan_emu.cpp Adds syscfg persistence and bounds for simulated client count and switches to HAL interface map API.
src/external_agent_cci/wlan_ext_emu_test_step_param_sta_management.cpp Removes is_decoded reset on external agent step path.
inc/wlan_emu_sta_mgr.h Updates public STA manager API signatures for per-client operations and interface-map init.
inc/wlan_emu_common.h Introduces connected_client_info_t and extends sta_test_t with multi-client / IP / DHCP fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/gateway_cci/wlan_emu.cpp
Comment thread src/gateway_cci/wlan_emu.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/sta/wlan_emu_sta_mgr.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
Comment thread src/tests/wlan_emu_test_param_sta_management.cpp
@gsathish86 gsathish86 merged commit 0476647 into rdkcentral:main Jun 16, 2026
2 of 3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants