XB10-2661: If radio BE mode/enable changes, re-apply VAP subdocs to re-resolve MLO groups#1223
Merged
Merged
Conversation
…e-resolve MLO groups
Reason for change: Disabling "be" on main link breaks MLO VAPS
Test Procedure: Configure MLO. Disable "be" on radio.
Check that MLO VAPs are reconfigured properly.
Risks: Low
Priority: P1
Signed-off-by: Petro Krynytskyi <Petr0krynytskiy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an MLO (Multi-Link Operation) reconfiguration issue where disabling 802.11be (“BE mode”) on a radio can leave MLO VAPs mis-grouped. It ensures MLO group resolution is re-evaluated when a radio’s BE capability or enable state changes.
Changes:
- Add an MLO-capability gate in
update_mld_groups()so VAPs are excluded from MLO when their radio is not enabled and BE-capable. - Detect radio enable/BE-variant transitions during radio apply and re-inject relevant fronthaul VAP subdocs so the normal apply pipeline re-runs MLO grouping logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/core/wifi_ctrl.c |
Adds a helper to determine radio MLO capability and uses it to exclude ineligible radios from MLO grouping. |
source/core/wifi_ctrl_webconfig.c |
Adds logic to detect radio enable/BE transitions and re-inject VAP subdocs to force MLO group re-resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
narendradandu
previously approved these changes
Jun 24, 2026
Aniket0606
reviewed
Jun 24, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
narendradandu
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Disabling "be" on main link breaks MLO VAPS
Test Procedure: Configure MLO. Disable "be" on radio, disable/enable the radio.
Check that MLO VAPs are reconfigured properly.
Risks: Low
Priority: P1