RDKB-64347: Fixing coverity issues#1221
Open
bharathivelp wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses low-priority Coverity findings by tightening string/buffer handling in WiFi TR-181/DML and WiFi DB code paths to reduce overflow/truncation risks.
Changes:
- Extend
getSecurityStringFromInt()to accept an explicit destination buffer size and switch tosnprintf()-based writes. - Update TR-181
ModeEnabledgetter to call the newgetSecurityStringFromInt()signature. - Harden
last_reboot_reasonretrieval by adding length-aware APIs and ensuring NUL-termination when copying bus/PSM values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
source/dml/tr_181/sbapi/cosa_wifi_apis.c |
Adds buffer-size parameter and safer append/copy logic for security-mode string conversion. |
source/dml/tr_181/ml/cosa_wifi_dml.c |
Updates caller to pass buffer size for security-mode conversion. |
source/db/wifi_db_apis.c |
Makes last-reboot-reason retrieval length-aware and improves safe copying / error handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+450
to
+454
| currentLen = AnscSizeOfString(securityName); | ||
| if (currentLen != 0) | ||
| { | ||
| strcat(securityName, ","); | ||
| strcat(securityName, wifiSecMap[i].wifiSecType); | ||
| if (currentLen >= bufSize) | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com