RDKB-64347: Fixing coverity issues#1220
Open
bharathivelp wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses low-priority Coverity findings by removing a nested helper function from a handler and eliminating a local-variable shadowing case in the tree rotation code.
Changes:
- Hoisted
to_sta_key()out ofwifiapi_handle_get_ApAssocDeviceDiagnosticResult()into a file-scopestatichelper. - Renamed a shadowing local variable in
ds_bst_rotate()(dir→pdir) to avoid confusion/static-analysis warnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/core/wifi_ctrl_wifiapi_handlers.c |
Moves to_sta_key() to file scope; handler continues to format associated-device diagnostic output. |
lib/ds/ds_tree.c |
Renames a shadowing local variable in the BST rotate helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+58
to
+63
| static char* to_sta_key(uint8_t *mac_address, sta_key_t sta_key) { | ||
| snprintf(sta_key, STA_KEY_LEN, "%02x:%02x:%02x:%02x:%02x:%02x", | ||
| mac_address[0], mac_address[1], mac_address[2], | ||
| mac_address[3], mac_address[4], mac_address[5]); | ||
| return sta_key; | ||
| } |
Comment on lines
634
to
636
| snprintf(result_buf, result_buf_size, "diag result: number of devs: %d\n", num_devs); | ||
| for (unsigned int i = 0; i < num_devs; i++) { | ||
| snprintf(result_buf, result_buf_size, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com