RDKB-64347: Fixing coverity issues#1217
Open
bharathivelp wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses low-priority Coverity findings by replacing potentially unsafe string copies, removing unused variables/logic, and eliminating a dead store after free().
Changes:
- Replaced a
strcpy()with a boundedsnprintf()when setting the default Passpoint HESSID. - Removed an unused
retvariable and simplified HAL apply analytics status reporting on the success path. - Removed a dead assignment (
buff = NULL) immediately afterfree(buff).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
source/core/wifi_passpoint.c |
Uses bounded formatting to avoid potential buffer overflow when setting default HESSID. |
source/core/wifi_ctrl_webconfig.c |
Cleans up unused variable and simplifies success status string construction for analytics. |
source/apps/blaster/wifi_single_client_msmt.c |
Removes dead store after free() to satisfy static analysis. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com