Skip to content

RDKB-64347: Fixing coverity issues#1217

Open
bharathivelp wants to merge 1 commit into
rdkcentral:developfrom
bharathivelp:RDKB-MCoverity_fixes
Open

RDKB-64347: Fixing coverity issues#1217
bharathivelp wants to merge 1 commit into
rdkcentral:developfrom
bharathivelp:RDKB-MCoverity_fixes

Conversation

@bharathivelp

Copy link
Copy Markdown
Contributor

Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
 
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com

Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
 
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com
Copilot AI review requested due to automatic review settings June 23, 2026 06:46
@bharathivelp bharathivelp requested a review from a team as a code owner June 23, 2026 06:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses low-priority Coverity findings by replacing potentially unsafe string copies, removing unused variables/logic, and eliminating a dead store after free().

Changes:

  • Replaced a strcpy() with a bounded snprintf() when setting the default Passpoint HESSID.
  • Removed an unused ret variable and simplified HAL apply analytics status reporting on the success path.
  • Removed a dead assignment (buff = NULL) immediately after free(buff).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
source/core/wifi_passpoint.c Uses bounded formatting to avoid potential buffer overflow when setting default HESSID.
source/core/wifi_ctrl_webconfig.c Cleans up unused variable and simplifies success status string construction for analytics.
source/apps/blaster/wifi_single_client_msmt.c Removes dead store after free() to satisfy static analysis.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants