RDKBWIFI-472: Add support to ignore disassociation imminent in BTM requests#1215
Open
santhoshg6 wants to merge 1 commit into
Open
RDKBWIFI-472: Add support to ignore disassociation imminent in BTM requests#1215santhoshg6 wants to merge 1 commit into
santhoshg6 wants to merge 1 commit into
Conversation
…quests
Add support to control the disassociation imminent indication in BTM requests via a new TR-181 parameter:
Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_Ignore11vDisassoc.
Enhance wifi_setBTMRequest to allow configuring disassociation imminent and timer values, which were previously fixed to 0.
Changes:
• Added TR-181 parameter for per-VAP configuration
• Propagated configuration through OneWifi control path to HAL (stubbed)
• Extended wifi_api2 command to accept disassoc imminent and timer inputs
Risks: Low – feature is optional and backward compatible.
Signed-off-by: sgunasekaran@maxlinear.com
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new per-AccessPoint TR-181 control to influence 802.11v BTM request behavior (specifically around disassociation-imminent handling), and extends the control path from RBUS/TR-181 through the controller queue to the HAL (stubbed), plus extends the wifi_api2 CLI BTM request inputs.
Changes:
- Added a new TR-181 parameter string constant and RBUS handler to push an “ignore disassoc” command into the controller queue.
- Introduced a new command/event subtype and queue handler to forward the setting to the HAL.
- Extended
wifi_setBTMRequesthandling to accept disassoc-imminent and timer inputs (previously fixed).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| source/utils/wifi_util.h | Adds a command payload struct for the new controller-queue command. |
| source/core/wifi_events.c | Adds stringification support for the new command subtype. |
| source/core/wifi_ctrl_wifiapi_handlers.c | Extends wifi_setBTMRequest parsing to include disassoc-imminent + timer. |
| source/core/wifi_ctrl_rbus_handlers.c | Adds RBUS setter for the new TR-181 parameter and registers it. |
| source/core/wifi_ctrl_queue_handlers.c | Adds controller-queue processing for the new command and dispatches it. |
| include/wifi_events.h | Adds a new command subtype enum value. |
| include/wifi_base.h | Defines the TR-181 parameter name macro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+411
to
+416
| btm_request->requestMode = BTM_REQMODE_PREF_LIST_INCL | | ||
| ((num_args > 4 && atoi(args[4])) ? BTM_REQMODE_DISASSOC_IMMINENT : 0); | ||
| btm_request->timer = (num_args > 5) ? (USHORT)atoi(args[5]) : 0; | ||
| btm_request->validityInterval = 0xFF; | ||
| btm_request->disassociationImminent = | ||
| (btm_request->requestMode & BTM_REQMODE_DISASSOC_IMMINENT) ? 1 : 0; |
Comment on lines
+4296
to
+4300
| if (ret != 1 || ap_idx < 1 || ap_idx > MAX_VAP) { | ||
| wifi_util_error_print(WIFI_CTRL, "%s:%d: Invalid vap index %u\n", | ||
| __func__, __LINE__, ap_idx); | ||
| return bus_error_destination_not_found; | ||
| } |
Comment on lines
+4488
to
+4490
| { WIFI_IGNORE_DISASSOC_IMMINENT, bus_element_type_method, | ||
| { NULL, set_IgnoreDisassocTimer, NULL, NULL, NULL, NULL }, slow_speed, ZERO_TABLE, | ||
| { bus_data_type_boolean, true, 0, 0, 0, NULL } }, |
Comment on lines
+4276
to
+4280
| bus_error_t set_IgnoreDisassocTimer(char *name, raw_data_t *p_data, bus_user_data_t *user_data) | ||
| { | ||
| int ap_idx = 0, ret; | ||
| bool enable = false; | ||
| ignore_disassoc_timer_cmd_t cmd; |
Comment on lines
+4507
to
+4509
| case wifi_event_type_command_setIgnoreDisassocTimer: | ||
| process_setIgnoreDisassocTimer_command(ctrl, data, len); | ||
| break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to control the disassociation imminent indication in BTM requests via a new TR-181 parameter: Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_Ignore11vDisassoc.
Enhance wifi_setBTMRequest to allow configuring disassociation imminent and timer values, which were previously fixed to 0. Changes:
• Added TR-181 parameter for per-VAP configuration • Propagated configuration through OneWifi control path to HAL (stubbed) • Extended wifi_api2 command to accept disassoc imminent and timer inputs.
Signed-off-by: sgunasekaran@maxlinear.com