RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3#1199
Open
SsandhyaR wants to merge 2 commits into
Open
RDKBDEV-3454, RDKBACCL-1879 : Upstream Onewifi changes for MP4.3#1199SsandhyaR wants to merge 2 commits into
SsandhyaR wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes build breaks on kernel 6.12 by switching to renamed/moved 802.11 EHT/MLO constants for a specific platform configuration.
Changes:
- Adds kernel/platform-conditional compilation to use
MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILEinstead ofEHT_ML_SUB_ELEM_PER_STA_PROFILE. - Adds kernel/platform-conditional compilation to use
BASIC_MLE_STA_CTRL_PRES_STA_MACinstead ofEHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mateuszCieslak-GL
requested changes
Jun 18, 2026
mateuszCieslak-GL
approved these changes
Jun 19, 2026
Reason for change: In Latest build of Kernel_6_12, below issues are seen
| ../../../git/source/core/../../source/apps/levl/wifi_levl.c:518:30: error: 'EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK' undeclared (first use in this function)
| 518 | if (!(sta_ctrl & EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK)) {
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/../../git/source/core/../../source/apps/levl/wifi_levl.c:505:34: error: 'EHT_ML_SUB_ELEM_PER_STA_PROFILE' undeclared (first use in this function); did you mean 'MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE'?
| 505 | for_each_element_id(sub, EHT_ML_SUB_ELEM_PER_STA_PROFILE, sub_start, sub_len)
| |
Test procedure : bitbake ccsp-one-wifi, wifi connectivity should work in
kernel-6.12
Risks: Low
Signed-off-by: ssiras826 <sandhyarani_sirasanagandla@comcast.com>
mateuszCieslak-GL
force-pushed
the
kernel_6_12
branch
from
574d31a to
3b5f7fd
Compare
Contributor
|
@SsandhyaR |
SsandhyaR
changed the title
Contributor
Author
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: In Latest build of Kernel_6_12, below issues are seen | ../../../git/source/core/../../source/apps/levl/wifi_levl.c:518:30: error: 'EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK' undeclared (first use in this function)
| 518 | if (!(sta_ctrl & EHT_PER_STA_CTRL_MAC_ADDR_PRESENT_MSK)) {
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/../../git/source/core/../../source/apps/levl/wifi_levl.c:505:34: error: 'EHT_ML_SUB_ELEM_PER_STA_PROFILE' undeclared (first use in this function); did you mean 'MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE'?
| 505 | for_each_element_id(sub, EHT_ML_SUB_ELEM_PER_STA_PROFILE, sub_start, sub_len)
| |
Test procedure : bitbake ccsp-one-wifi, wifi connectivity should work in
kernel-6.12
Risks: Low