RDKCOM-5597: RDKBDEV-3453, RDKBWIFI-459 Add Device.WiFi.EM.FailedConnection RBUS event#1167
Open
santhoshg6 wants to merge 2 commits into
Open
RDKCOM-5597: RDKBDEV-3453, RDKBWIFI-459 Add Device.WiFi.EM.FailedConnection RBUS event#1167santhoshg6 wants to merge 2 commits into
santhoshg6 wants to merge 2 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds WiFi connection-failure telemetry by emitting new HAL events for pre/post association failures and publishing a corresponding EM bus event for consumers.
Changes:
- Emit
wifi_event_hal_pre_assoc_fail/wifi_event_hal_post_assoc_failfrom monitor path before interop STA-map lookups. - Add EM bus event
Device.WiFi.EM.FailedConnectionand handlers to publish a failure payload. - Introduce shared
sta_fail_data_tcarrier for status/reason codes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| source/stats/wifi_monitor.c | Push new pre/post-association failure HAL events early in status/reason handlers |
| include/wifi_events.h | Add new HAL event subtypes for failed-connection reporting |
| include/wifi_base.h | Add sta_fail_data_t struct used to carry status/reason + STA MAC + ap_index |
| source/apps/em/wifi_em.h | Add EM event name constant and a failure-connection payload struct/comment |
| source/apps/em/wifi_em.c | Handle new HAL events and publish FailedConnection bus event as JSON |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
santhoshg6
force-pushed
the
RDKBWIFI-459
branch
2 times, most recently
from
2ecf961 to
439d802
Compare
santhoshg6
force-pushed
the
RDKBWIFI-459
branch
2 times, most recently
from
a65e552 to
e77819d
Compare
santhoshg6
force-pushed
the
RDKBWIFI-459
branch
2 times, most recently
from
d7944ad to
0664207
Compare
santhoshg6
force-pushed
the
RDKBWIFI-459
branch
2 times, most recently
from
d830e01 to
e6dba30
Compare
Contributor
|
Internal build: https://gerrit.teamccp.com/959661 - success |
narendradandu
previously approved these changes
Jun 22, 2026
Reason for change: When a Wi-Fi client fails to connect due to authentication or association failure (e.g., wrong password, MIC failure, ACL deny), there is no RBUS event to notify upper layers about the failure. This change introduces the Device.WiFi.EM.FailedConnection event that is published on connection failure, carrying the BSSID, station MAC, IEEE 802.11 status code, and reason code as a JSON payload. Test Procedure: 1. WPA3-SAE wrong password — verified event published with status=15 (SAE Challenge Failure), reason=0 2. WPA2-PSK wrong password — verified event published with status=0, reason=14 (MIC Failure) 3. ACL deny (blacklist) — verified event published with status=33 (Unspecified/ACL deny), reason=0 All scenarios validated via RBUS subscriber and packet capture on rdkb-lgm platform. Risks: Low. New RBUS event only; no modification to existing connection or data path logic. No impact on normal association flow. Signed-off-by: sgunasekaran@maxlinear.com
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
When a Wi-Fi client fails to connect due to authentication or association failure (e.g., wrong password, MIC failure, ACL deny), there is no RBUS event to notify upper layers about the failure. This change introduces the Device.WiFi.EM.FailedConnection event that is published on connection failure, carrying the BSSID, station MAC, IEEE 802.11 status code, and reason code as a JSON payload.
Test Procedure:
Risks:
Low. New RBUS event only; no modification to existing connection or data path logic. No impact on normal association flow.
Signed-off-by: sgunasekaran@maxlinear.com