RDKBWIFI-454: Added station RSSI (unassociated STA statistics) implementation by vlad-safonov · Pull Request #1157 · rdkcentral/OneWifi

vlad-safonov · 2026-05-29T13:40:36Z

Reason for change: added implementation of new RBUS method "Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_GetNaSta". Aslo added support unassoc STA datamodel in the Easymesh translator

Dependent PR: rdk-wifi-hal/#721, rdkb-halif-wifi/#109

Test procedure: Execute rbus request: Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_GetNaSta
with Json string, e.g.

  "Version": "1.0",
  "SubDocName": "UnassocStaQuery",
  "UnassocStaQueryList": [
    {
      "opclass": 115,
      "channels_length": 2,
      "channels": [
        {
          "channel": 36,
          "sta_list_length": 2,
          "sta_macs": ["AA:BB:CC:DD:EE:01", "AA:BB:CC:DD:EE:02"]
        },
        {
          "channel": 40,
          "sta_list_length": 1,
          "sta_macs": ["AA:BB:CC:DD:EE:03"]
        }
      ]
    },
    {
      "opclass": 128,
      "channels_length": 1,
      "channels": [
        {
          "channel": 40,
          "sta_list_length": 1,
          "sta_macs": ["AA:BB:CC:DD:EE:04"]
        }
      ]
    }
  ]
}

and subscribe for rbus event Device.WiFi.EM.NaStaResponse:, expect to get response, like this

{
  "UnassociatedSTALinkMetricsResponse": {
    "num_sta": 2,
    "sta_list": [
      {
        "sta_mac": "AA:BB:CC:DD:EE:FF",
        "channel": 6,
        "op_class": 81,
        "rcpi": 120
      },
      {
        "sta_mac": "11:22:33:44:55:66",
        "channel": 36,
        "op_class": 115,
        "rcpi": 95
      }
    ],
  }
}

Note: Channel parameter:
The primary channel is expected in "UnassocStaQuery" JSON. "op_class" and primary channel are used internally to calculate center frequency and bandwidth.

RCPI:

MAX_RSSI = MAX(RSSI[ant0]...RSSI[ant4]);
RCPI = (MAX_RSSI + 110) * 2;
RCPI = CLAP(RCPI, 0, 220);

Priority: P2
Risks: Low

rdkcmf-jenkins · 2026-05-29T13:41:16Z

b'## Copyright scan failure
Commit: 57708ce
Report detail: https://gist.github.com/rdkcmf-jenkins/b578d829cf751f171fddb51314ed8651'

rdkcmf-jenkins · 2026-05-29T13:42:03Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: 57708ce

Report detail: gist'

rdkcmf-jenkins · 2026-05-29T14:31:32Z

b'## Copyright scan failure
Commit: ac79d94
Report detail: https://gist.github.com/rdkcmf-jenkins/b807dcb2ebfc2eb703bf1e649dc89436'

rdkcmf-jenkins · 2026-05-29T14:32:22Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: ac79d94

Report detail: gist'

vlad-safonov · 2026-05-29T14:36:54Z

I have read the CLA Document and I hereby sign the CLA

rdkcmf-jenkins · 2026-06-01T09:37:06Z

b'## Copyright scan failure
Commit: c6613ee
Report detail: https://gist.github.com/rdkcmf-jenkins/91b9e37f107cdb5612c5af07dd0ad959'

rdkcmf-jenkins · 2026-06-01T09:37:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: c6613ee

Report detail: gist'

rdkcmf-jenkins · 2026-06-01T13:13:00Z

b'## Copyright scan failure
Commit: ca4a5a3
Report detail: https://gist.github.com/rdkcmf-jenkins/a921424702e64f2fad7225396af30281'

rdkcmf-jenkins · 2026-06-01T13:13:50Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: ca4a5a3

Report detail: gist'

rdkcmf-jenkins · 2026-06-01T13:52:08Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: ca4a5a3

Report detail: gist'

mhughesacn · 2026-06-01T13:58:03Z

Hi @vlad-safonov : Please add a credit for MaxLinear to the end of the NOTICE file at the top level in this component:

Copyright 2026 MaxLinear, Inc
Licensed under the Apache License, Version 2.0

and I will clear off the checks.
Thank you - MartinH, RDK CMF Compliance Team

rdkcmf-jenkins · 2026-06-01T14:55:49Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/OneWifi/1157/rdkb/components/opensource/ccsp/OneWifi
Commit: 9cb0642

Report detail: gist'

rdkcmf-jenkins · 2026-06-01T15:23:54Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Thank you
Commit: 9cb0642
'

Copilot

Pull request overview

This PR adds support for unassociated station (NaSta) RSSI statistics by introducing a new WebConfig subdoc (UnassocStaQuery), wiring it into the controller apply path, and exposing a new RBUS method Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_GetNaSta that publishes results asynchronously via Device.WiFi.EM.NaStaResponse.

Changes:

Add UnassocStaQuery WebConfig subdoc with request decode + response encode.
Add controller apply logic to call wifi_getNASta() and publish an async RBUS response event.
Add an RBUS test utility (wifi_rbus) plus MXL-specific scaffolding for wifi_api2.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
source/webconfig/wifi_webconfig.c	Registers the new `webconfig_subdoc_type_nasta_query` subdoc.
source/webconfig/wifi_webconfig_nasta.c	Implements NaSta query decode and response encode logic.
source/webconfig/Makefile.am	Adds `wifi_webconfig_nasta.c` to `libwifi_webconfig` sources.
source/test/wifi_rbus.c	New RBUS CLI tool to invoke `X_RDKCENTRAL-COM_GetNaSta` and print async response.
source/test/Makefile.am	Builds and links the new `wifi_rbus` test utility.
source/core/wifi_ctrl_wifiapi_handlers.c	Adds MXL-gated inclusion of extra wifi_api2 entries (currently problematic).
source/core/wifi_ctrl_webconfig.c	Adds `webconfig_nasta_apply()` to execute HAL calls and publish response event.
source/core/wifi_ctrl_rbus_handlers.c	Adds RBUS method handler `get_NaSta` and registers method/event elements.
source/core/wifi_ctrl_queue_handlers.c	Routes new queue subtype `wifi_event_webconfig_set_data_nasta` through webconfig decode/apply.
source/core/mxl_wifi_ctrl_wifiapi_handlers.h	Declares MXL wifi_api2 list macro and handler prototype (currently mismatched).
source/core/mxl_wifi_ctrl_wifiapi_handlers.c	Adds MXL handler implementation for `wifi_getNASta` (scaffolding).
source/core/Makefile.am	Conditionally builds MXL handler implementation when `MXL_WIFI` is enabled.
include/wifi_webconfig.h	Adds new subdoc/object types and decoded data fields for NaSta.
include/wifi_events.h	Adds new event subtype `wifi_event_webconfig_set_data_nasta`.
include/wifi_base.h	Adds NaSta RBUS method/event names and query/response structures and limits.
configure.ac	Adds `AM_CONDITIONAL([MXL_WIFI], ...)`.
NOTICE	Adds MaxLinear 2026 notice entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

+    /* Extract VapIndex (injected by RBUS handler) */
+    cJSON *vap_idx_obj = cJSON_GetObjectItem(json, "VapIndex");
+    if (vap_idx_obj && cJSON_IsNumber(vap_idx_obj)) {
+        query->vap_index = (unsigned int)cJSON_GetNumberValue(vap_idx_obj);
+    }
+


+    cJSON_AddNumberToObject(json, "VapIndex", vap_idx - 1);
+    enriched_str = cJSON_PrintUnformatted(json);


+        webconfig_decode(config, data, raw);
+        webconfig_data_free(data);


Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

+    if (outParams != NULL) {
+        char *ack = strdup("{\"Status\":\"Accepted\"}");
+        if (ack != NULL) {
+            outParams->value.data_type = bus_data_type_string;
+            outParams->value.raw_data.bytes = ack;
+            outParams->value.raw_data_len = strlen(ack);
+        }
+    }


+        wifi_util_error_print(WIFI_CTRL, "%s:%d Failed to parse JSON input\r\n", __func__, __LINE__);
+        return bus_error_invalid_input;
+    }
+    cJSON_AddNumberToObject(json, "VapIndex", vap_idx - 1);


Nikita-Hakai · 2026-06-19T06:25:34Z

 #define HOTSPOT_CLIENT_DHCP_FAILURE_DISCONNECTED       "Device.X_COMCAST-COM_GRE.Hotspot.RejectAssociatedClient"
 #define WIFI_STUCK_DETECT_FILE_NAME         "/nvram/wifi_stuck_detect"
+#define WIFI_ACCESSPOINT_GET_NASTA          "Device.WiFi.AccessPoint.{i}.X_RDKCENTRAL-COM_GetNaSta"
+#define WIFI_NASTA_RESPONSE_EVENT           "Device.WiFi.EM.NaStaResponse"


For Device.WiFi.EM.XXXX specific data, can we maintain in wifi_em files

we will review and address all comments

Nikita-Hakai · 2026-06-19T06:28:03Z

+                                { WIFI_ACCESSPOINT_GET_NASTA, bus_element_type_method,
+                                    { NULL, NULL, NULL, NULL, NULL, get_NaSta }, slow_speed, ZERO_TABLE,
+                                    { bus_data_type_string, true, 0, 0, 0, NULL } },
+                                { WIFI_NASTA_RESPONSE_EVENT, bus_element_type_event,


This event seems specific to Easymesh only right? If so, can this be managed in wifi_em.c including the publish part?

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

+    if (outParams != NULL) {
+        char *ack = strdup("{\"Status\":\"Accepted\"}");
+        if (ack != NULL) {
+            outParams->value.data_type = bus_data_type_string;
+            outParams->value.raw_data.bytes = ack;
+            outParams->value.raw_data_len = strlen(ack);
+        }
+    }


…_NaSta and rbus handlers integration

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

+        wifi_util_error_print(WIFI_CTRL, "%s:%d Failed to parse JSON input\r\n", __func__, __LINE__);
+        return bus_error_invalid_input;
+    }
+    cJSON_AddNumberToObject(json, "VapIndex", vap_idx - 1);


    config->subdocs[webconfig_subdoc_type_ignite].translate_to_subdoc = translate_to_ignite_subdoc;
    config->subdocs[webconfig_subdoc_type_ignite].translate_from_subdoc = translate_from_ignite_subdoc;

+    //webconfig_subdoc_type_nasta_query


+        }
+
+        cJSON *oc_val = cJSON_GetObjectItem(opclass_obj, "opclass");
+        if (!oc_val || !cJSON_IsNumber(oc_val)) {


+            }
+
+            cJSON *ch_val = cJSON_GetObjectItem(chan_obj, "channel");
+            if (!ch_val || !cJSON_IsNumber(ch_val)) {


+            outParams->value.data_type = bus_data_type_string;
+            outParams->value.raw_data.bytes = ack;
+            outParams->value.raw_data_len = strlen(ack) + 1;
+        }


+        if (ack != NULL) {
+            outParams->value.data_type = bus_data_type_string;
+            outParams->value.raw_data.bytes = ack;
+            outParams->value.raw_data_len = strlen(ack) + 1;


+    /* Extract VapIndex (injected by RBUS handler) */
+    cJSON *vap_idx_obj = cJSON_GetObjectItem(json, "VapIndex");
+    if (vap_idx_obj && cJSON_IsNumber(vap_idx_obj)) {
+        query->vap_index = (unsigned int)cJSON_GetNumberValue(vap_idx_obj);
+    }


vlad-safonov requested a review from a team as a code owner May 29, 2026 13:40

vlad-safonov marked this pull request as draft May 29, 2026 13:40

github-actions Bot added the community contribution Contributions from community. label May 29, 2026

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch from 173a212 to ac79d94 Compare May 29, 2026 13:50

vlad-safonov marked this pull request as ready for review May 29, 2026 14:28

vlad-safonov changed the title ~~Added station RSSI (unassociated STA statistics) implementation~~ RDKBWIFI-454: Added station RSSI (unassociated STA statistics) implementation May 29, 2026

vlad-safonov marked this pull request as draft June 1, 2026 09:57

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch 3 times, most recently from ec58522 to ca4a5a3 Compare June 1, 2026 13:11

vlad-safonov marked this pull request as ready for review June 1, 2026 13:12

Nikita-Hakai requested a review from Copilot June 2, 2026 22:27

Copilot started reviewing on behalf of Nikita-Hakai June 2, 2026 22:27 View session

Nikita-Hakai reviewed Jun 2, 2026

View reviewed changes

Comment thread source/webconfig/Makefile.am

Copilot AI reviewed Jun 2, 2026

View reviewed changes

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch 2 times, most recently from 5c0537b to abf59e3 Compare June 3, 2026 13:51

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch from 1f4f726 to 0affe1a Compare June 18, 2026 12:32

Copilot started reviewing on behalf of vlad-safonov June 18, 2026 12:33 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 18, 2026 13:16

Copilot started reviewing on behalf of vlad-safonov June 18, 2026 13:16 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch from b73d7a6 to 15a907d Compare June 18, 2026 14:52

Nikita-Hakai reviewed Jun 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 19, 2026 14:09

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch from 15a907d to efafdd2 Compare June 19, 2026 14:09

Copilot started reviewing on behalf of vlad-safonov June 19, 2026 14:09 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

vlad-safonov and others added 11 commits June 19, 2026 18:21

Added station RSSI (unassociated STA statistics) implementation - get…

869de75

…_NaSta and rbus handlers integration

Added support for webconfig_subdoc_type_nasta_query

04cef79

Added a credit for MaxLinear in NOTICE

13fec73

changed sscanf specificator to %u for vap_idx

56c2690

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

webconfig nasta added for linux and openwrt builds

06b6878

set correct raw_data_len as strlen + 1

7ed5172

aligned names with rdk-wifi-halif

a3b8d44

added missed webconfig subtypes to wifi_event_subtype_to_string

3fb5b10

removed unused headers

a4ec0a6

added static const to nasta_query_objects definitions

7f1742f

removed data->u.encoded.json = json

06ec7b7

vlad-safonov force-pushed the RDKBWIFI-454-adding-station-RSSI branch from 3fac0de to 06ec7b7 Compare June 19, 2026 15:21

vlad-safonov added 2 commits June 19, 2026 08:31

added space for NUL-symbol in value.raw_data_len

f07193a

marked unused var asyncHandle in get_NaSta func

2fa3919

Copilot AI review requested due to automatic review settings June 19, 2026 15:40

Copilot started reviewing on behalf of vlad-safonov June 19, 2026 15:40 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

		cJSON_AddNumberToObject(json, "VapIndex", vap_idx - 1);
		enriched_str = cJSON_PrintUnformatted(json);

		webconfig_decode(config, data, raw);
		webconfig_data_free(data);

Conversation

vlad-safonov commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 29, 2026

Uh oh!

rdkcmf-jenkins commented May 29, 2026

Uh oh!

rdkcmf-jenkins commented May 29, 2026

Uh oh!

rdkcmf-jenkins commented May 29, 2026

Uh oh!

vlad-safonov commented May 29, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

mhughesacn commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

rdkcmf-jenkins commented Jun 1, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Nikita-Hakai Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

vlad-safonov Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Nikita-Hakai Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

vlad-safonov commented May 29, 2026 •

edited

Loading

Nikita-Hakai Jun 19, 2026 •

edited

Loading