Skip to content

RDKEMW-18340: Improve Minidump naming and crash-time fireboltState selection#454

Open
Sonajeya31 wants to merge 4 commits into
rdkcentral:developfrom
Sonajeya31:topic/RDKEMW-18340-1
Open

RDKEMW-18340: Improve Minidump naming and crash-time fireboltState selection#454
Sonajeya31 wants to merge 4 commits into
rdkcentral:developfrom
Sonajeya31:topic/RDKEMW-18340-1

Conversation

@Sonajeya31

@Sonajeya31 Sonajeya31 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description:
Integrates minidump fixes directly in Dobby by improving crash-time fireboltState selection and trimming container names using apps_ so dump filenames use a cleaner app identifier

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Copilot AI review requested due to automatic review settings June 11, 2026 19:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves minidump filename generation by aligning it with the actual crash time and ensuring the recorded fireboltState reflects the state at (or before) the crash, even if the annotation changes shortly after.

Changes:

  • Pass the minidump FD into destination-path generation to derive crash time from the file’s mtime (with ms resolution fallback).
  • Add annotation timestamping and “previous value” preservation to support crash-time state reconstruction.
  • Adjust minidump naming to use crash-time-valid fireboltState and normalize container IDs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
rdkPlugins/Minidump/source/Minidump.h Updates getDestinationFile signature to accept an FD.
rdkPlugins/Minidump/source/Minidump.cpp Computes crash-time from fd stat, selects correct fireboltState based on timestamps, trims containerId for filename.
pluginLauncher/lib/source/DobbyRdkPluginUtils.cpp Stores <key>_ts, <key>_prev, and <key>_prev_ts when adding annotations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rdkPlugins/Minidump/source/Minidump.cpp
Comment thread rdkPlugins/Minidump/source/Minidump.cpp
Comment thread pluginLauncher/lib/source/DobbyRdkPluginUtils.cpp
Comment thread rdkPlugins/Minidump/source/Minidump.cpp Outdated
Copilot AI review requested due to automatic review settings June 23, 2026 10:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread pluginLauncher/lib/source/DobbyRdkPluginUtils.cpp
Comment thread pluginLauncher/lib/source/DobbyRdkPluginUtils.cpp
Comment thread rdkPlugins/Minidump/source/Minidump.cpp
Comment thread rdkPlugins/Minidump/source/Minidump.cpp
@Sonajeya31 Sonajeya31 changed the title RDKEMW-18340: Remove patch from meta-rdk-comcast and apply in dobby RDKEMW-18340: Improve Minidump naming and crash-time fireboltState selection Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants