Avoid looping forever if core pinning fails#104
Closed
IagoAbal wants to merge 1 commit into
Closed
Conversation
This is known to happen, under some circumstances, on Apple M1. Plus code cleanup. Closes rdicosmo#103
Author
|
Be aware that I have not done extensive testing of these changes! For now I have jut ran |
Owner
|
Thanks for looking into this. It is difficult to follow the diff you proposed, though: there is code that is moved untouched in a separate subroutine, and it is not clear what the proposed change really is. |
3 tasks
Owner
|
@IagoAbal thank you for the original analysis and patch — sorry this stalled for so long. I have opened #116 with just the loop-bound logic change you wrote (no refactor), as requested in the 2021 review. You are credited in the commit message. Closing this in favor of #116. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is known to happen, under some circumstances, on Apple M1.
Plus code cleanup.
Closes #103