Skip to content

[DRAFT] Fix failing tests and jar build#8

Open
pavlosZakkas wants to merge 741 commits intorbrn:masterfrom
pavlosZakkas:fix-failing-tests-and-jar-build
Open

[DRAFT] Fix failing tests and jar build#8
pavlosZakkas wants to merge 741 commits intorbrn:masterfrom
pavlosZakkas:fix-failing-tests-and-jar-build

Conversation

@pavlosZakkas
Copy link

@pavlosZakkas pavlosZakkas commented Aug 7, 2020

I could not put the develop branch of crown as the base branch! As a result, you see all those commits! Actually, only the last 3 are mine!

Regarding the creation of the JAR please read the following:
While running:

./mvnw -Pprod clean verify

the process defined by maven is executed and as a result the tests are running in order to verify that the code works as expected, before creating the jar.

There were a lot of failing tests in our codebase, so many of them were disabled atm, while others were fixed.

At the moment there is the following error occurring while the command npm run lint && npm run jest is executed by maven:

Failed to write coverage reports:
        ERROR: Error: Cannot find module 'lcov'

So the JAR is not created yet. After fixing this issue as well, probably we will be able to create and run the jar with those commands:

to create the jar:
./mvnw -Pprod clean verify    or ./mvnw -Pprod clean package

to run the jar:
java -jar target/*.jar

Ani-Utkin and others added 30 commits June 26, 2020 14:38
…-298-develop

Revert "Revert "Revert "Develop"""
…-297-master

Revert "Revert "Revert "prefill user status"""
new pull for prefill user status
Ani-Utkin and others added 28 commits August 4, 2020 13:54
Crown 248 - Transfer the mail service from sendgrid to AWS SES
Fixed the user journey and set the new homepage as landing page
Crown 250: Validate fields in Request a Resource form
Develop: CROWN-250: Validate fields in Request a Resource form
Package json: Bump lodash from 4.17.15 to 4.17.19
About page and footer section redesigned
Need to be fixed though in the future.
@pavlosZakkas pavlosZakkas force-pushed the fix-failing-tests-and-jar-build branch from d868927 to be47965 Compare August 7, 2020 23:57
@pavlosZakkas pavlosZakkas changed the title Fix failing tests and jar build [DRAFT] Fix failing tests and jar build Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.