[DRAFT] Fix failing tests and jar build#8
Open
pavlosZakkas wants to merge 741 commits intorbrn:masterfrom
Open
[DRAFT] Fix failing tests and jar build#8pavlosZakkas wants to merge 741 commits intorbrn:masterfrom
pavlosZakkas wants to merge 741 commits intorbrn:masterfrom
Conversation
prefill user status
Revert "prefill user status"
Revert "Develop"
Revert "Revert "Develop""
Revert "Revert "prefill user status""
updates on prefill and doc
…-298-develop Revert "Revert "Revert "Develop"""
Revert "updates on prefill and doc"
Revert "document fix"
…-297-master Revert "Revert "Revert "prefill user status"""
new pull for prefill user status
Revert 307 prefill fix
Crown 248 - Transfer the mail service from sendgrid to AWS SES
Fixed the user journey and set the new homepage as landing page
Crown 250: Validate fields in Request a Resource form
Develop: CROWN-250: Validate fields in Request a Resource form
Package json: Bump lodash from 4.17.15 to 4.17.19
Changes to package.json.
change file path.
Revert "Crown 265"
About page and footer section redesigned
Need to be fixed though in the future.
d868927 to
be47965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not put the develop branch of crown as the base branch! As a result, you see all those commits! Actually, only the last 3 are mine!
Regarding the creation of the JAR please read the following:
While running:
the process defined by maven is executed and as a result the tests are running in order to verify that the code works as expected, before creating the jar.
There were a lot of failing tests in our codebase, so many of them were disabled atm, while others were fixed.
At the moment there is the following error occurring while the command
npm run lint && npm run jestis executed by maven:So the JAR is not created yet. After fixing this issue as well, probably we will be able to create and run the jar with those commands: