Update semversioner check to use git#50
Open
darthtrevino wants to merge 2 commits intoraulgomis:masterfrom
Open
Update semversioner check to use git#50darthtrevino wants to merge 2 commits intoraulgomis:masterfrom
semversioner check to use git#50darthtrevino wants to merge 2 commits intoraulgomis:masterfrom
Conversation
semversioner check to use git
Owner
|
Hi @darthtrevino , thanks for this idea and code contribution. For now, I wouldn't like to couple this tool with any version control system in order to keep things simple and tool agnostic. I guess you could run the git diff external to the tool, can't you? Cheers, |
Contributor
Author
|
Sure, I can do that, but the #!/bin/sh
changes=$(git diff --name-only origin/main)
has_change_doc=$(echo $changes | grep .semversioner/next-release)
has_impacting_changes=$(echo $changes | grep my-project)
if [ "$has_impacting_changes" ] && [ -z "$has_change_doc" ]; then
echo "Check failed. Run 'poetry run semversioner add-change' to update the next release version"
exit 1
fi
echo "OK" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
checkcommand to interact with git to ensure that there is a change-document for the current branch if any impacted files are touched.Fixes #48