Fix TPC-DS integration tests: handle NULLs in ORDER BY validation#347
Open
Avinash-Raj wants to merge 8 commits into
Open
Fix TPC-DS integration tests: handle NULLs in ORDER BY validation#347Avinash-Raj wants to merge 8 commits into
Avinash-Raj wants to merge 8 commits into
Conversation
Staging branch manifest for N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: '<' not supported between instances of 'str' and 'float'(andfloat and str, andNoneType and NoneType) — see "Root cause" below.presto/testing/requirements.txtandspark_gluten/testing/requirements.txt).After this PR
pytest common/testing/result_comparison_test.pyis 22/22 green (was 15/17 before this branch, ignoring the new tests).Failing job
presto-nightlyrun 26017210785, job 76471406344—
pinned / presto-test / integration-test (tpcds, presto-gpu-cuda13.1, amd64, l4).Stack trace, identical for all 17 failures: