Skip to content

Fix TPC-DS integration tests: handle NULLs in ORDER BY validation#347

Open
Avinash-Raj wants to merge 8 commits into
mainfrom
fix/result-comparison-orderby-nulls
Open

Fix TPC-DS integration tests: handle NULLs in ORDER BY validation#347
Avinash-Raj wants to merge 8 commits into
mainfrom
fix/result-comparison-orderby-nulls

Conversation

@Avinash-Raj
Copy link
Copy Markdown
Contributor

Summary

  • Fixes 17 TPC-DS integration tests that started failing in presto-nightly #122 with TypeError: '<' not supported between instances of 'str' and 'float' (and float and str, and NoneType and NoneType) — see "Root cause" below.
  • Adds 6 new regression tests covering the failure shapes.
  • Also un-breaks 2 preexisting unit tests in the same file that no longer worked under pandas 3.x (the version pinned in
    presto/testing/requirements.txt and spark_gluten/testing/requirements.txt).

After this PR pytest common/testing/result_comparison_test.py is 22/22 green (was 15/17 before this branch, ignoring the new tests).

Failing job

presto-nightly run 26017210785, job 76471406344
pinned / presto-test / integration-test (tpcds, presto-gpu-cuda13.1, amd64, l4).

Stack trace, identical for all 17 failures:

(130 durations < 0.005s hidden.  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q5] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q15] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q20] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q23] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q30] - TypeError: '<' not supported between instances of 'float' and 'str'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q45] - TypeError: '<' not supported between instances of 'float' and 'str'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q46] - TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q50] - TypeError: '<' not supported between instances of 'float' and 'str'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q62] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q65] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q66] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q68] - TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q77] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q80] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q81] - TypeError: '<' not supported between instances of 'float' and 'str'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q98] - TypeError: '<' not supported between instances of 'str' and 'float'
FAILED ../testing/integration_tests/tpcds_test.py::test_query[Q99] - TypeError: '<' not supported between instances of 'str' and 'float'
============ 17 failed, 49 passed, 16 warnings in 243.74s (0:04:03) ============

@Avinash-Raj Avinash-Raj requested a review from a team as a code owner May 18, 2026 14:28
@Avinash-Raj Avinash-Raj requested a review from devavret May 18, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant