Fix GPU TPC-H benchmark: migrate to --cudf_properties flag#346
Closed
Avinash-Raj wants to merge 7 commits into
Closed
Fix GPU TPC-H benchmark: migrate to --cudf_properties flag#346Avinash-Raj wants to merge 7 commits into
Avinash-Raj wants to merge 7 commits into
Conversation
…rapidsai/velox-testing into fix/cudf-tpch-benchmark-properties-flag
bdice
approved these changes
May 18, 2026
Contributor
Author
|
Closing this as a duplicate of #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cuDF TPC-H benchmark binary no longer accepts
--cudf_memory_resource/--cudf_memory_percent; upstream velox PR facebookincubator/velox#16357 replaced them with a single--cudf_properties=<file>flag that loads a key=value properties file.velox/benchmarks/tpch.shwas still passing the removed flag, so every GPU TPC-H run aborted at startup withERROR: unknown command line flag 'cudf_memory_resource'. Repro:velox-nightly #125 → benchmark-velox-gpu (tpch, cuda13.1, amd64, a100).
Updated the GPU branch of
run_tpch_single_benchmarkto materialize/tmp/cudf_q<NN>.propertiesinside the container (single line:cudf.memory_resource=async) and pass--cudf_properties=<path>to thebinary. CPU path is unchanged.