Fix manual run IDs and speed up arch tag cleanup#345
Open
bdice wants to merge 4 commits into
Open
Conversation
Contributor
|
/ok to test d9874e2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cleanup step was taking more than 6 minutes to run because it was fetching all pages of the container registry, once for every image being deleted. The updates in
ci/delete-arch-tags.shnow fetch only enough pages needed to resolve the IDs for the desired tags, which now only takes a second or two to run.Since that is so much faster, I also moved the
presto-depsimage cleanup and refactored the otherprestoimage builds to use the merged manifests rather than the arch-specific intermediates.Testing