Fix devcontainer build-all dependency handling#341
Draft
bdice wants to merge 4 commits into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvfst).-j0in the Velox and Presto wrappers resolve to CPU count instead ofulimit -Hn; the previous behavior expanded to 500000 jobs and filled the filesystem during CMake/build.s2geometryin the Presto wrapper soVELOX_DEPENDENCY_SOURCE=SYSTEMdoes not make the embedded Velox configure fail looking for a systems2geometrypackage.Debugging Notes
ucxx-cu13being installed is not necessarily wrong for CUDA 13 binary packages, but the source build path should be used for this devcontainer flow.ucxx_ROOTwiring fromb7f1d00, and the live wrapper was synced so downstream CMake receives-Ducxx_ROOT=/home/coder/ucxx/cpp/build/pip/cuda-13.1/release.librmmeditable build failures through scikit-build'scmake.prefixentry point loading (No module named 'ucxx._lib.libucxx'). Removing stale UCXX binary wheels let source UCXX rebuild normally.boost_iostreamsdependency, then the missings2geometrybundled override, then the-j0job explosion / disk pressure issue.Validation
build-all -j0completed RAPIDS, Velox, and Presto after applying these changes and cleaning/rebuilding./opt/velox-build/release/velox/experimental/cudf/tests/velox_cudf_config_test/opt/presto-build/presto_cpp/main/presto_server/opt/presto-build/presto_cpp/main/tests/presto_server_testucxx 0.50.00rmm 26.06.00cudf 26.06.00kvikio 26.06.00Known Follow-up
python -m pip checkstill reportslibucxx 0.50.0 requires libucx, while this CUDA 13 environment haslibucx-cu13. Runtime imports work, but editable source package metadata is not fully aligned with the suffixed UCX runtime package.