Handle both flat and nested scale_factor in metadata.json#319
Open
misiugodfrey wants to merge 1 commit into
Open
Handle both flat and nested scale_factor in metadata.json#319misiugodfrey wants to merge 1 commit into
misiugodfrey wants to merge 1 commit into
Conversation
Datasets with a newer metadata format nest scale_factor under an "options" key. Update get_scale_factor_from_file() to try the top-level key first and fall back to options.scale_factor, and update error messages in Presto and Spark Gluten test utils to document both formats.
devavret
approved these changes
Apr 23, 2026
Contributor
paul-aiyedun
left a comment
paul-aiyedun
left a comment
There was a problem hiding this comment.
Please hold off on this. There is ongoing work to unify the metadata format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datasets with a newer metadata format nest scale_factor under an "options" key. Update get_scale_factor_from_file() to try the top-level key first and fall back to options.scale_factor, and update error messages in Presto and Spark Gluten test utils to document both formats.