This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Convert . in CUDA version to _ for rattler-build compat#151
Merged
Conversation
Error: × Parsing: failed to parse match spec: the build string '12.9_py313_250626*' is not valid, it can only contain alphanumeric characters and underscores
╭─[402:7]
401 │ - pynndescent 0.5.13 pyhd8ed1ab_1
402 │ - pynvjitlink 0.7.0 12.9_py313_250626*
· ──────────────────┬─────────────────
· ╰── error parsing `pynvjitlink 0.7.0 12.9_py313_250626*` as a match spec
403 │ - pynvml 12.0.0 pyhd8ed1ab_0
msarahan
added
bug
gforsyth
reviewed
Jul 21, 2025
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
gforsyth
approved these changes
Jul 28, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rattler-build trips on our build string (which I'm hitting because I'm working on pinning stuff). I see 2 ways around this: convert to an underscore, which isn't optimal because it is a delimiter elsewhere in the build string, or removing the "." and cramming the minor version in.
This is pretty esoteric, so I don't think it'll matter much either way, but we should do something about this, or else we won't be able to include this package in pins (for example, work in rapidsai/cuml#7015)