This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Add missing Thrust includes#539
Merged
Merged
Conversation
github-actions
Bot
added
cmake
harrism
approved these changes
May 25, 2022
Member
|
Oops, still a draft, I jumped the gun. |
8 tasks
Member
|
Seems to be a problem with CUDA Python? |
harrism
approved these changes
Jun 16, 2022
harrism
added
improvement
Contributor
Author
|
Commit 1efbffd passes CI, but I wasn't able to locate a I saw one occurrence here but it seems to be from libcudf: I will open the PR draft once we confirm that cuspatial will behave correctly with Thrust 1.17 and revert the |
Contributor
Author
vyasr
approved these changes
Jun 17, 2022
Contributor
|
@gpucibot merge |
isVoid
pushed a commit
to isVoid/cuspatial
that referenced
this pull request
Jun 23, 2022
## Description This PR cleans up some `#include`s for Thrust. This is meant to help with the transition to Thrust 1.17 when that is updated in rapids-cmake (rapidsai/rapids-cmake#199). ## Context Version 1.16 of Thrust reduced the number of internal header inclusions: > [rapidsai#1572](NVIDIA/thrust#1572) Removed several unnecessary header includes. Downstream projects may need to update their includes if they were relying on this behavior. I am making similar changes across all RAPIDS libraries to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up some
#includes for Thrust. This is meant to help with the transition to Thrust 1.17 when that is updated in rapids-cmake (rapidsai/rapids-cmake#199).Context
Version 1.16 of Thrust reduced the number of internal header inclusions:
I am making similar changes across all RAPIDS libraries to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust.