Skip to content

add encoding for read md file#482

Open
Lchiffon wants to merge 4 commits into
ramnathv:masterfrom
Lchiffon:master
Open

add encoding for read md file#482
Lchiffon wants to merge 4 commits into
ramnathv:masterfrom
Lchiffon:master

Conversation

@Lchiffon

Copy link
Copy Markdown

read_file function should have a rgument for encoding="UTF-8"

Can't use Chinese character in Windows without that~

@GegznaV GegznaV left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lchiffon your suggestion to add encoding="UTF-8" in read_file is really helpful. It enabled me to have possibility to use my native language in slidify slides. I hope your bug fixes and pull request will be accepted shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants