Windows wants double quotes; should work for Linux / Unix as well.#433
Open
ptressel wants to merge 1 commit into
Open
Windows wants double quotes; should work for Linux / Unix as well.#433ptressel wants to merge 1 commit into
ptressel wants to merge 1 commit into
Conversation
Author
|
I forgot Github doesn't send notifications about pull requests, but only about comments(!) so I'm adding a comment just to send a notification (sorry!). Let me know if any work needs to be done. I've tested on Windows, and other kind folks have tested on Mac and Linux (where there was no visible change, as expected). I also updated the pull request description to include links to the original issue and diagnosis. |
Owner
|
Thanks @ptressel I will get this merged shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now tested on Windows, MacOS, Linux. ;-)
Original trouble report was included in a comment in this issue (but was not the main subject of that issue):
#419
Here's the comment:
#419 (comment)
Symptom is that publish gets this error:
error: pathspec 'Commit'' did not match any file(s) known to git.
DIagnosis is here:
#419 (comment)