Fixes issue with closing div for nested list fields#226
Open
jamesinglis wants to merge 1 commit intoraideus:masterfrom
Open
Fixes issue with closing div for nested list fields#226jamesinglis wants to merge 1 commit intoraideus:masterfrom
jamesinglis wants to merge 1 commit intoraideus:masterfrom
Conversation
Nested list fields were returning before outputting the closing </div> for the element, causing validation issues and in some cases breaking the DOM. Changing the control structure saves adding another "$output .= '</div>';" before the earlier return statement.
|
Found this bug and fixed in my own copy. When came here to create pull-request for it I found it was already fixed by this @Bootsz Could this one be merged? No conflicts with master. It's clearly a bug and it's breaking the form layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested list fields were returning before outputting the closing for the element, causing validation issues and in some cases breaking the DOM. Changing the control structure saves adding another "$output .= '';" before the earlier return statement.