Conversation
update `pick_a_worker` to use the `purpose` argument instead of `lock_path` - callers shouldn't know the method's implementation details (e.g. that it uses file locks). Additionally, the code is updated to work correctly with multiple instances (e.g. different Rage apps are running on the same server on different ports) and all lock files are now stored in an array to protect from GC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how singleton worker processes are selected for running periodic tasks and Redis Pub/Sub listeners, and improves the deferred task scheduler for better reliability and development ergonomics. The main changes include replacing ad-hoc lock file management with a purpose-based locking mechanism, updating scheduler logging, and enhancing code clarity.
Worker Process Selection & Locking:
Rage::Internal.pick_a_workerto require apurpose:argument instead of an optionallock_path, generating a unique lock file per purpose and ensuring proper lock cleanup on process exit.Deferred Scheduler Improvements:
Rage::Deferred::Schedulerto use the newpick_a_worker(purpose:)interface, improved logging, and added development-mode logic to reload task classes dynamically.ref #277