Open
Conversation
technically, it should always be initialized if called inside a request fiber. But there could still be cases when it's not, for example in a handshake span. It wouldn't make much sense, but just to be safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a wait generation mechanism to the fiber scheduler and fiber coordination logic. The main goal is to prevent stale resumes by ensuring that only the most recent wait or block operation on a fiber can resume it. This is achieved by tracking a generation counter (
__wait_generation) that is incremented on each wait-related operation. The changes also update the fiber scheduler to implement thefiber_interruptmethod.