Make it possible to opt out of focus handling#90
Open
Haraldson wants to merge 7 commits intorafgraph:mainfrom
Open
Make it possible to opt out of focus handling#90Haraldson wants to merge 7 commits intorafgraph:mainfrom
Haraldson wants to merge 7 commits intorafgraph:mainfrom
Conversation
Author
|
Did a lil’ self-review and noticed my brain did a derp. This code will work as intended in my use case, or for people who explicitly defined the prop, but not for anyone else. The JavaScript flavor here seems fairly modern, but I don’t see any default values in function signatures, null-coalescing operators or similar. What’s your preferred way of defining default values, @rafgraph? |
`handleFocus` (needed to be set to `true` to retain current focus behavior, a breaking change) -> `preventFocusHandling` (needs to be explicitly set to `true` to opt out of current focus behavior, non-breaking).
Owner
|
Thanks for the PR. Generally looks good, thanks for One important change, the |
rafgraph
reviewed
Oct 7, 2021
rafgraph
reviewed
Oct 7, 2021
Author
|
I hope and think that should do it, @rafgraph! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible bonus: Regard contenteditables as interactive elements, but I understand if you don’t want this as part of the same PR, or have considered this before and concluded that it’s best to leave them out.
I’m not entirely sure about the flow of arguments here and whether it could be simplified or flow in a more natural way, but it seems to be working as intended.
Fixes #89