improve(router/classify): Nemotron COMPLEX review cycle (hour 0 UTC)#176
Open
raelli wants to merge 1 commit into
Open
improve(router/classify): Nemotron COMPLEX review cycle (hour 0 UTC)#176raelli wants to merge 1 commit into
raelli wants to merge 1 commit into
Conversation
Replace Object.prototype.hasOwnProperty.call with Object.hasOwn for the complexityHint tier lookup — identical runtime behaviour on Node 16+, cleaner and more idiomatic. Prototype-key guard (issue #79) is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YYKb4s7A3CR9JG1HV3JDy7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated self-improvement pass on
src/router/classify.js. Router review timed out (90 s); improvements applied via own analysis — tests pass.Change
Replace
Object.prototype.hasOwnProperty.call(HINT_TO_CODING_TIER, normalizedHint)withObject.hasOwn(HINT_TO_CODING_TIER, normalizedHint)on thecomplexityHinttier-lookup guard.Object.prototypeindirection in favour of the ES2022 static method."toString"/"constructor"inputs) is fully preserved —Object.hasOwnreturnsfalsefor inherited properties just likehasOwnProperty.call.Test plan
npx jest tests/router-classify.test.js— 119 tests pass (prototype-key regression tests for issue **<sub><sub></sub></sub> Reject inherited complexityHint keys** #79 included)pnpm test— 750 tests pass, 0 failuresnode bin/improve-guard.js— ok (1 file, 2 lines)Generated by Claude Code