improve(router/workflow): Nemotron COMPLEX review cycle (hour 1 UTC)#175
Open
raelli wants to merge 1 commit into
Open
improve(router/workflow): Nemotron COMPLEX review cycle (hour 1 UTC)#175raelli wants to merge 1 commit into
raelli wants to merge 1 commit into
Conversation
- Add upfront dep guard in runWorkflow for early, clear failure - Emit modelTier as "SIMPLE" fallback when task.nemotronTier is unset - Normalize validator return value; fail closed on malformed results - Document that pre-revision in complex workflow does not consume loop budget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated self-improvement pass on
src/router/workflow.js. Reviewed by Nemotron COMPLEX — tests pass.Changes
runWorkflow: validates thatdeps.emit,deps.codingClient, anddeps.nemotronClientare present before entering the switch. Fails fast with a clear message instead of aTypeErrordeep in the call stack.modelTiertelemetry consistency: when not escalated, emits"SIMPLE"as themodelTierfallback whentask.nemotronTieris unset, keeping telemetry aligned with the resolved model.failureKind: "validator-malformed") on malformed results, preventing aTypeErroronnullor unexpected shapes.runComplexWorkflowintentionally does not consume the loop'srevisionCountbudget.Test results
750 tests, 46 suites — all pass.
Generated by Claude Code