improve(skills/dev-advisor): Nemotron COMPLEX review cycle (hour 12 UTC)#174
Open
raelli wants to merge 1 commit into
Open
improve(skills/dev-advisor): Nemotron COMPLEX review cycle (hour 12 UTC)#174raelli wants to merge 1 commit into
raelli wants to merge 1 commit into
Conversation
Log HTTP status on non-OK advisor responses so auth failures, rate limits, and server errors are diagnosable in production logs, consistent with the existing fetch-error logging at the catch site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated self-improvement pass on
src/skills/dev-advisor/index.js. Reviewed by Nemotron COMPLEX — tests pass.Change
Add
logger.warnwhen the LLM advisor endpoint returns a non-2xx HTTP status (!res.ok), logging the status code before the fail-openreturn null.Before: non-OK responses were silently swallowed, making auth failures (401), rate limits (429), and server errors (5xx) invisible in logs.
After: a single
warnline is emitted with the HTTP status, consistent with the existinglogger.errorcall in the fetch-error catch block. The fail-open contract (returnnull→ fall through toRulesAdvisor) is unchanged.Test plan
pnpm test— 750/750 tests pass before and after the changenode bin/improve-guard.js— 0 files, 0 lines flaggedGenerated by Claude Code