[fp8] Select SGLang FP8 block quant kernel to match inference#1182
Open
yueming-yuan wants to merge 1 commit into
Open
[fp8] Select SGLang FP8 block quant kernel to match inference#1182yueming-yuan wants to merge 1 commit into
yueming-yuan wants to merge 1 commit into
Conversation
yueming-yuan
requested review from
Zhichenzzz,
fzyzcjy,
maocheng23 and
yushengsu-thu
as code owners
yueming-yuan
force-pushed
the
fp8-quant-kernel-selection
branch
from
bcd5394 to
4aee1fc
Compare
yueming-yuan
force-pushed
the
fp8-quant-kernel-selection
branch
from
4aee1fc to
b6ccb11
Compare
yueming-yuan
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates the per_block_cast_to_fp8 function from the sglang library into the FP8 quantization workflow. It introduces a new internal helper, _blockwise_cast_to_fp8, which conditionally utilizes the sglang implementation when the weight block size is (128, 128) and falls back to the existing Triton-based kernel otherwise. Additionally, the sglang utility is safely imported with a fallback to None to ensure compatibility. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.