fix: add models ConfigMap checksum and correct docs defaults#6
Merged
dhilgaertner merged 2 commits intomainfrom Mar 9, 2026
Merged
fix: add models ConfigMap checksum and correct docs defaults#6dhilgaertner merged 2 commits intomainfrom
dhilgaertner merged 2 commits intomainfrom
Conversation
…ate documentation
Add checksum/models annotation to deployment so pods restart when modelsConfig changes via helm upgrade. Fix CONFIGURATION.md defaults for guardrails.openaiModeration and passthrough.enabled to match values.yaml (both are true, not false). Closes #3 Closes #4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dgershman
reviewed
Mar 9, 2026
Collaborator
dgershman
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None — no blocking issues found.
Security Review
Strengths:
checksum/modelsannotation correctly ensures pods restart when model configuration changes, preventing stale config drift- Template syntax is correct and consistent with existing
checksum/envandchecksum/secretpatterns .gitignoreadditions are appropriate for developer tooling files
Concerns:
logging.requestBodyandlogging.responseBodychanged fromfalse→trueinvalues.yaml— This is a behavioral default change, not just a docs fix, but it's not mentioned in the PR description. Enabling request/response body logging by default means sensitive user data (prompts, completions, potentially PII) will be stored in logs. The chart itself notes this "increases storage usage". For a gateway handling LLM traffic, defaulting to full body logging could have privacy implications. Consider whether this should default tofalsefor safety, or at minimum document this as an intentional change in the PR description.- Similarly,
guardrails.openaiModerationandpassthrough.enabledwere changed fromfalse→truein bothvalues.yamland docs. The PR description frames these as docs-only fixes, but they are also behavioral changes to defaults. If the values.yaml onmainalready had these astrue, disregard — but the diff shows they werefalseon main.
Code Quality
checksum/modelsannotation attemplates/deployment.yaml:19— clean, follows existing convention- Helm lint passes with no errors
helm templaterenders all three checksum annotations correctly.gitignore:.playwright-mcp/and.claude/settings.local.jsonare reasonable additions- Minor: PR also adds
uiSessionSecret: ""to values.yaml (visible in full diff vs main) which isn't mentioned in the PR description
Summary Table
| Priority | Issue |
|---|---|
| 🟡 Yellow | Logging defaults changed to true — potential privacy/storage concern, undocumented in PR description |
| 🟡 Yellow | PR description says "fix docs defaults" but values.yaml defaults also changed for guardrails, passthrough, and logging |
| 🟢 Green | Undocumented uiSessionSecret addition to values.yaml |
Recommendation: Comment — The core fix (checksum/models annotation) is solid. The docs alignment work is good. However, I'd like clarity on whether the values.yaml default changes (especially logging body capture) are intentional behavioral changes or accidental. If intentional, the PR description should reflect that these are default changes, not just docs fixes.
Contributor
Author
|
@dgershman yes intentional values.yaml defaults changed after doing some testing and that request/response logging was off by default in helm chart values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checksum/modelsannotation to deployment so pods restart whenmodelsConfigchanges viahelm upgrade(fixes Bug: Models ConfigMap checksum missing from deployment annotations #3)docs/CONFIGURATION.mddefaults forguardrails.openaiModerationandpassthrough.enabledto matchvalues.yaml(fixes Docs: Wrong defaults in CONFIGURATION.md #4)Changes
templates/deployment.yaml: Addedchecksum/modelsannotation alongside existingchecksum/envandchecksum/secretdocs/CONFIGURATION.md: Changed default values fromfalsetotrueforopenaiModerationandpassthrough.enabledTest plan
helm templaterenders all three checksum annotations correctlyvalues.yamlhelm upgradewith changedmodelsConfigtriggers pod rolloutCloses #3
Closes #4
🤖 Generated with Claude Code